4 replies to this topic

[Mr. Z]

I'm working on a mine cart script that drives over Raft flags, automatically turns around corners (prefers left over right) and throws you out when you hit a dead end.
And it works, but there are some things not entirely right with it.

-When I put multiple carts on a screen, Link teleports from cart to cart and they all do not move properly. (This teleporting created inspiration for my next script :V)
-If you manage to leave the screen on a cart or while jumping out, all of the carts stop working, even the ones on other screens.
-How can I switch the ffc flag "Draw Over" to make it appear over Link while he's riding it?

Spoiler

CODE

const int CART_GRAPHIC=724; //Proper cart graphics not yet set, right now the cart just looks like the selected ffc. (Link also appears on top of it)
const int TRACK_FLAG=8; //The flag number of the track the cart will follow. Standard set to Raft Path. (Don't use docks)
const int CART_SPEED=1; //The speed of the cart.
const int ALLOW_SWORD=0; //Allows use of the sword while in the cart.

int riding=0;
int hspeed=0;
int vspeed=0;
int cartdirection=0;

ffc script MineCart{
    void run(){

        while(true){

        int xlink=Link->X+8;
        int ylink=Link->Y+8;
        int xpos=this->X+8;
        int ypos=this->Y+8;

            if(ComboAt(xlink,ylink)==ComboAt(xpos,ypos) && riding==0){
                EnterCart(xpos,ypos);
                if(TrackAhead(1,xpos,ypos)==true){ cartdirection=1; }
                else if(TrackAhead(2,xpos,ypos)==true){ cartdirection=2; }
                else if(TrackAhead(3,xpos,ypos)==true){ cartdirection=3; }
                else if(TrackAhead(4,xpos,ypos)==true){ cartdirection=4; }
            }

            if(riding==2){

            Link->X=this->X;
            Link->Y=this->Y;
            this->Vx=hspeed;
            this->Vy=vspeed;

                if(this->Vy<0){ cartdirection=1; }
                if(this->Vy>0){ cartdirection=2; }
                if(this->Vx<0){ cartdirection=3; }
                if(this->Vx>0){ cartdirection=4; }

                if(ALLOW_SWORD==0){ Link->SwordJinx=2; }

            int loopcount=0;

                while(loopcount<5){
                    if(cartdirection==1){ //1 up -> 3 left -> 4 right
                        if(TrackAhead(1,xpos,ypos)==true){ vspeed=-CART_SPEED; }
                        else if(TrackAhead(1,xpos,ypos)==false){
                        vspeed=0;
                            if(TrackAhead(3,xpos,ypos)==true){ hspeed=-CART_SPEED; }
                            else if(TrackAhead(4,xpos,ypos)==true){ hspeed=CART_SPEED; }
                        }
                    }
                    if(cartdirection==2){ //2 down -> 4 right -> 3 left
                        if(TrackAhead(2,xpos,ypos)==true){ vspeed=CART_SPEED; }
                        else if(TrackAhead(2,xpos,ypos)==false){
                        vspeed=0;
                            if(TrackAhead(4,xpos,ypos)==true){ hspeed=CART_SPEED; }
                            else if(TrackAhead(3,xpos,ypos)==true){ hspeed=-CART_SPEED; }
                        }
                    }
                    if(cartdirection==3){ //3 left -> 2 down -> 1 up
                        if(TrackAhead(3,xpos,ypos)==true){ hspeed=-CART_SPEED; }
                        else if(TrackAhead(3,xpos,ypos)==false){
                        hspeed=0;
                            if(TrackAhead(2,xpos,ypos)==true){ vspeed=CART_SPEED; }
                            else if(TrackAhead(1,xpos,ypos)==true){ vspeed=-CART_SPEED; }
                        }
                    }
                    if(cartdirection==4){ //4 right -> 1 up -> 2 down
                        if(TrackAhead(4,xpos,ypos)==true){ hspeed=CART_SPEED; }
                        else if(TrackAhead(4,xpos,ypos)==false){
                        hspeed=0;
                            if(TrackAhead(1,xpos,ypos)==true){ vspeed=-CART_SPEED; }
                            else if(TrackAhead(2,xpos,ypos)==true){ vspeed=CART_SPEED; }
                        }
                    }
                loopcount++;
                if(loopcount==5 && hspeed==0 && vspeed==0){ riding=3; }
                }

            }

            if(riding==3){
                this->Vx=hspeed;
                this->Vy=vspeed;
                LeaveCart(cartdirection,xpos,ypos);
                cartdirection=0;
            }

        Waitframe();
        }

    }
} //MineCart


void EnterCart(int xpos, int ypos){
    riding=1;
    Link->Jump=2;
        for(int i=0; i<24; i++){
        NoAction();
        Waitframe();
        }
    riding=2;
} //EnterCart


void LeaveCart(int dir, int xpos, int ypos){
    riding=4;
    Link->Jump=2;
        for(int i=0; i<16; i++){
            if(dir==1){ Link->Y-=1; }
            if(dir==2){ Link->Y+=1; }
            if(dir==3){ Link->X-=1; }
            if(dir==4){ Link->X+=1; }
        NoAction();
        Waitframe();
        }
    riding=0;
    cartdirection;
} //LeaveCart


bool TrackAhead(int dir, int xpos, int ypos){
    int xdir=0;
    int ydir=0;

    if(dir==1){ ydir=-(8+CART_SPEED); }
    if(dir==2){ ydir=8+CART_SPEED; }
    if(dir==3){ xdir=-(8+CART_SPEED); }
    if(dir==4){ xdir=8+CART_SPEED; }

    if(Screen->ComboF[ComboAt(xpos+xdir,ypos+ydir)]==TRACK_FLAG || Screen->ComboI[ComboAt(xpos+xdir,ypos+ydir)]==TRACK_FLAG){
    return true;
    }
    else{ return false; }
} //TrackAhead

[MoscowModder]

For draw over: I think that's FFC->Flags[FFCF_OVERLAY].

[Mr. Z]

Okay, I fixed its layer and improved the code.

I still have the problem with the multiple carts though, any idea what causes that?

I also made some progress with the scrolling, but I can't find the proper function to stick the cart to Link as he scrolls between the screens. Right now, if you were to leave a screen at the bottom, the cart on the next screen will still appear at the bottom with Link in it, causing you to keep scrolling down until you hit the edge of the map.

Spoiler

CODE

import "Time Waster\std.zh"

const int CART_GRAPHIC=724; //Combo graphic for the cart when it's moving up. The other combos are faced down, left and right.
const int TRACK_FLAG=3; //The track the cart will follow. Standard set to Raft Path. (Don't use docks)
const int CART_STICK_OUT=2; //The number of pixels the cart appears over the track (place the ffc at the according height)
const int LINK_STICK_OUT=4; //The number of pixels Link appears above the cart

//D0 = cart's speed - 2 is decent, but don't go too high.
//D1 = disable sword while riding the cart

int riding=0;
int hspeed=0;
int vspeed=0;
int cartdirection=0;

ffc script MineCart{

    void run(int speed, int disablesword){

        while(true){

        int screen;
        int xlink=Link->X+8;
        int ylink=Link->Y+8;
        int xpos=this->X+8;
        int ypos=this->Y+8+CART_STICK_OUT;

            if(ComboAt(xlink,ylink)==ComboAt(xpos,ypos) && riding==0){
                EnterCart(xpos,ypos);
                if(TrackAhead(speed,1,xpos,ypos)==true){ cartdirection=1; }
                else if(TrackAhead(speed,2,xpos,ypos)==true){ cartdirection=2; }
                else if(TrackAhead(speed,3,xpos,ypos)==true){ cartdirection=3; }
                else if(TrackAhead(speed,4,xpos,ypos)==true){ cartdirection=4; }
            }

            if(riding==2){

            this->Flags[FFCF_CARRYOVER]=true;
            this->Flags[FFCF_OVERLAY]=true;

            Link->X=this->X;
            Link->Y=this->Y-LINK_STICK_OUT;
            this->Vx=hspeed;
            this->Vy=vspeed;
            this->Data=CART_GRAPHIC-1+cartdirection;

                if(this->Vy<0){ cartdirection=1; }
                if(this->Vy>0){ cartdirection=2; }
                if(this->Vx<0){ cartdirection=3; }
                if(this->Vx>0){ cartdirection=4; }

                if(disablesword==1){ Link->SwordJinx=2; }

            int loopcount=0;

                while(loopcount<5){
                    if(cartdirection==1){ //1 up -> 3 left -> 4 right
                        if(TrackAhead(speed,1,xpos,ypos)==true){ vspeed=-speed; }
                        else if(TrackAhead(speed,1,xpos,ypos)==false){
                        vspeed=0;
                            if(TrackAhead(speed,3,xpos,ypos)==true){ hspeed=-speed; }
                            else if(TrackAhead(speed,4,xpos,ypos)==true){ hspeed=speed; }
                        }
                    }
                    if(cartdirection==2){ //2 down -> 4 right -> 3 left
                        if(TrackAhead(speed,2,xpos,ypos)==true){ vspeed=speed; }
                        else if(TrackAhead(speed,2,xpos,ypos)==false){
                        vspeed=0;
                            if(TrackAhead(speed,4,xpos,ypos)==true){ hspeed=speed; }
                            else if(TrackAhead(speed,3,xpos,ypos)==true){ hspeed=-speed; }
                        }
                    }
                    if(cartdirection==3){ //3 left -> 2 down -> 1 up
                        if(TrackAhead(speed,3,xpos,ypos)==true){ hspeed=-speed; }
                        else if(TrackAhead(speed,3,xpos,ypos)==false){
                        hspeed=0;
                            if(TrackAhead(speed,2,xpos,ypos)==true){ vspeed=speed; }
                            else if(TrackAhead(speed,1,xpos,ypos)==true){ vspeed=-speed; }
                        }
                    }
                    if(cartdirection==4){ //4 right -> 1 up -> 2 down
                        if(TrackAhead(speed,4,xpos,ypos)==true){ hspeed=speed; }
                        else if(TrackAhead(speed,4,xpos,ypos)==false){
                        hspeed=0;
                            if(TrackAhead(speed,1,xpos,ypos)==true){ vspeed=-speed; }
                            else if(TrackAhead(speed,2,xpos,ypos)==true){ vspeed=speed; }
                        }
                    }
                loopcount++;
                if(loopcount==5 && hspeed==0 && vspeed==0){ riding=3; }
                }

            }

            if(riding==3){
                this->Flags[FFCF_OVERLAY]=false;
                this->Vx=hspeed;
                this->Vy=vspeed;
                LeaveCart(cartdirection,xpos,ypos);
                cartdirection=0;
            }

        Waitframe();
        }

    this->Flags[FFCF_CARRYOVER]=false;
    }
} //MineCart


void EnterCart(int xpos, int ypos){
    riding=1;
    Link->Jump=2;
        for(int i=0; i<24; i++){
        NoAction();
        Waitframe();
        }
    riding=2;
} //EnterCart


void LeaveCart(int dir, int xpos, int ypos){
    riding=4;
    Link->Jump=2;
        for(int i=0; i<16; i++){
            if(dir==1){ Link->Y-=1; }
            if(dir==2){ Link->Y+=1; }
            if(dir==3){ Link->X-=1; }
            if(dir==4){ Link->X+=1; }
        NoAction();
        Waitframe();
        }
    riding=0;
    cartdirection;
} //LeaveCart


bool TrackAhead(int speed,int dir, int xpos, int ypos){
    int xdir=0;
    int ydir=0;

    if(dir==1){ ydir=-(8+speed); }
    if(dir==2){ ydir=8+speed; }
    if(dir==3){ xdir=-(8+speed); }
    if(dir==4){ xdir=8+speed; }

    if(
        Screen->ComboF[ComboAt(xpos+xdir,ypos+ydir)]==TRACK_FLAG ||
        Screen->ComboI[ComboAt(xpos+xdir,ypos+ydir)]==TRACK_FLAG ||
        xpos+xdir>16*16 || xpos-xdir<0 || ypos+ydir>11*16 || ypos-ydir<0
        ){ return true; }
    else{ return false; }
} //TrackAhead

[MoscowModder]

It can't help that you have the riding variables as global variables. I'm guessing that's what's causing your teleportation problem.

As for motion between screens, you enable "FFC carries over" on the minecart FFCs, as long as each screen the cart can visit has its FFC slot empty.

To place it on Link, store the current screen each frame, and when the screen changes, place the cart on Link's current position.

[aaa2]

How about i give you a fitting structure for your script in pseudo code

CODE

bool link_in_cart;
ffc script MineCart{
    void run(){

        while(true){
             if(link_in_cart){ //if you are in the cart when you change a screen the cart will be moved to link
                    position_cart_at_link();
                     cart();
                     cart_exit();
               }
              if(link_enters_cart()){
                    cart_entry();
                     cart();
                     cart_exit();
              }
              Waitframe();
        }
}
void cart_entry(){
    link_in_cart=true;  //make sure the game registers you entered the cart
    //the animation code for entering the cart goes here
}
void cart_exit(){
// the animation for when link exits the cart goes here
  link_in_cart=false; //make sure the game registers link is not a cart anymore
}
void position_cart_at_link(){
\\ this function should move the cart to link fast after you change screen if you are in the cart
}
void cart(){
     //here you should write what the minecart does while link is in it each frame
     Waitframe();
}
bool link_enters_cart(){
    bool b=false;
     //check here if link steps on the cart if he does set b to true
     return b;
}

With this structure your script should work fine and bugfree.


Things are always simpler if you write everything you want your script to do in the main function without filling in any details. That way you get a structure early and can recognize possible problems early on. Plus your code will be very easy to read an maintain.


Also note with this structure you will also not need to do complicated things like storing screen positions each frame like moscow modder suggested because the structure takes away the work.

Edited by aaa2, 19 April 2013 - 03:44 PM.