Finished. Both endings sucked
SpoilerI feel the wallet upgrade is a pointless final to the trade quest. I already bought everything long before...especially because the Shovel makes rupee grinding super, super easy. Sword is fine where it is and under the conditions. The Tunic upgrade...I really like this idea. I've never seen something like this done before...in simply entering a 'locked in until finished' mini dungeon to get and use it...and keeping it is the prize for simply escaping. I'm missing a few HP's...but I'm not going to bother...There's already nothing left to challenge...and H.Spin isn't something I use frequently anyway...especially with nothing left to do or for it to even assist. I did enjoy this though. There were some very unique ideas implemented here.
Edit: As a last minute thought....there is really no 'good' or 'true' ending. As a future update if you want to expand this...add a secret dungeon and true final boss that requires both completion and 100%...plus a good ending that follows.
About the endings, the point of the story was to make the main character never win. Yes you could argue that it is a real let-down, but if you look beyond the ending from the main character's point of view, the ending where you let your sister live is the actual 'good' ending... for the Kingdom. It'll be explained why this is like this in the future, but for now, I'll just keep it at that. For the end of the trade sequence, I didn't really have anything else to add besides a wallet upgrade, so I decided to add it in as well as some more story elements. The characters mentioned in this part of the quest will be expanded in the future, so get ready for that!