44 replies to this topic

[Lejes]

Edited again. It should at least compile now, but I haven't tested it with Meropits because that script is a mess and I don't want to set it up in a test quest.

[Binx]

It's the checks. I had to add LA_RAFTING to the checks to get it to allow rafting. If you add a check to see if "OnPlatform == false", it should work.

EDIT: Oh, wait, never mind, you don't have a global variable for being on the platform, anymore.

Edited by Binx, 11 March 2016 - 04:39 PM.

[EJSnowden]

Edited again. It should at least compile now, but I haven't tested it with Meropits because that script is a mess and I don't want to set it up in a test quest.

It did compile this time. You were right, though, it didn't have any effect.

I wouldn't mind using a non-Mero script, but there's pretty much nothing else in the DB other than his that I can find.

[Binx]

It did compile this time. You were right, though, it didn't have any effect.

I wouldn't mind using a non-Mero script, but there's pretty much nothing else in the DB other than his that I can find.

Like I said, before, the problem is in the line 

if(Link->Action != LA_Scrolling)

 You need to add a check to that line to see if you're on the platform. Looking through the script you posted, you still have "bool OnPlatform(ffc this)", right?, if it's still there, change the above line to

 

if((Link->Action != LA_SCROLLING) && (OnPlatform(this) != true))

That *should* fix the problem. Not sure how it woud  done with Dimentio's script, since it doesn't use a global variable.

Edited by Binx, 11 March 2016 - 04:58 PM.

[EJSnowden]

Like I said, before, the problem is in the line 

if(Link->Action != LA_Scrolling)

 You need to add a check to that line to see if you're on the platform. Looking through the script you posted, you still have "bool OnPlatform(ffc this)", right?, if it's still there, change the above line to

 

if((Link->Action != LA_SCROLLING) && (OnPlatform(this) != true))

That *should* fix the problem. Not sure how it woud  done with Dimentio's script, since it doesn't use a global variable.

 

"Could not macth type signature."

[Binx]

Hmmmm. that's strange, probably a syntax error on my part. Or maybe it's that it isn't hard-coded to use a specific ffc...

Probably won't do anything but try changing 

OnPlatform(this) != true

to 

OnPlatform == false

Edited by Binx, 11 March 2016 - 05:32 PM.

[EJSnowden]

 

Hmmmm. that's strange, probably a syntax error on my part. Or maybe it's that it isn't hard-coded to use a specific ffc...

Probably won't do anything but try changing 

OnPlatform(this) != true

to 

OnPlatform == false

No good.

[Lejes]

Because that line is in the global script, and "this" only refers to an FFC within an FFC script.

[Deedee]

The alteration to Mero's script does use a global check to check if you are on a platform. If you want, I can fix the other pit scripts that you are using to check for if you are on a platform.

[Lejes]

Check my first post again. I missed that the platform script is just called "Platform", not "MovingPlatform".

[EJSnowden]

Check my first post again. I missed that the platform script is just called "Platform", not "MovingPlatform".

Still compiles, but platforms don't hold up over pits.

 

Here is my global as of now:

Spoiler

//G1.0 Global Script

global script Slot_2_GLB_Version{
   void run(){
   
   //StartGhostZH(); //! Enable if using ghost.zh
        InitHoleLava(); //Inits Tamamo's holes and lava.
   
   //UpdateGhostZH1();//! Enable if using ghost.zh
            GameboyShield(); //Handles the gameboy style shield, by MM.
   
   
   
   
   
   
     //Initialize variables used to store Link's strating position on Screen Init.
        int olddmap = Game->GetCurDMap();
        int oldscreen = Game->GetCurDMapScreen();
        int startx = Link->X;
        int starty = Link->Y;
        int startdir = Link->Dir;
 
        //Clear global variables used by Bottomless pits.
        Falling = 0;
        Warping = false;
   
   
   
    holding_block = 0;
      while(true){
      
       if(Link->Action != LA_SCROLLING)
            {
                Update_HoleLava(startx, starty, olddmap, oldscreen, startdir);
                if(Link->Z==0 && !Falling && (oldscreen != Game->GetCurDMapScreen() || olddmap != Game->GetCurDMap()))
                {
                    olddmap = Game->GetCurDMap();
                    oldscreen = Game->GetCurDMapScreen();
                    startx = Link->X;
                    starty = Link->Y;
                    startdir = Link->Dir;
                }
            }
    PowerBracelet();    

         GLB_Sideview_Ladder();                //********* (before waitdraw)

         Waitdraw();
        
         if (onLadder) Link->Dir = DIR_UP;     //********* (After Waitdraw)
     //UpdateGhostZH2(); //! Enable if using ghost.zh
            //LREx1Ex2ItemSwitch(); //! Enable if you want to allow A+B item switchign with Ex1/Ex2
            if (Link->Action != LA_SCROLLING ) RunHoleLava(); //Main Tamamo Holes and Lava function.

         Waitframe();

      }//end whileloop
   }//end run
}//end global slot2 Global Version

 

My platform script:

 

Spoiler

// F1.2 Moving Platform
//This function simply checks if that the center of Link is within the bounds of the ffc.


bool OnPlatform (ffc this){
    if(CenterLinkX() < this->X) return false;
    else if(CenterLinkX() >= this->X + this->EffectWidth) return false;
    else if(CenterLinkY() < this->Y) return false;
    else if(CenterLinkY() >= this->Y + this->EffectHeight) return false;
    else return true;
    }
    
//This script turns a moving ffc into a platform so it carries Link.
ffc script Platform{
    void run(){
        //Initialize two variables to store the position of the ffc the previous frame.
        float oldx = this->X;
        float oldy = this->Y;
        //Initialize two variables to store the change in Link's position each frame.
        float linkx;
        float linky;
        //Loop Indefinitely.
        while(true){
            //Check if Link is on the platform and is not mid-air.
            if(OnPlatform(this) && Link->Z == 0){
                //Increment linkx by the change in the ffc's position along the x axis.
                linkx += this->X - oldx;
                //Check if the absolute value of linkx truncated to an int doesn't = 0.
                if(linkx<<0 != 0){
                    //Increment link's position by linkx truncated removed.
                    Link->X += linkx<<0;
                    //Decrement linkx by itself rounded down.
                    linkx -= linkx<<0;
                }
                //Vertical Movement is the same as horizontal movement just along the y axis.
                linky += this->Y - oldy;
                if(linky<<0 != 0){
                    Link->Y += linky<<0;
                    linky -= linky<<0;
                }
            }
            //Set oldx and oldy to the ffc's current position.
            oldx = this->X;
            oldy = this->Y;
            //Waitframe to prevent lag.
            Waitframe();
        }
    }
}

And my pit script, which is mixed in with a shield item script (IIRC, it's Zoria's modification of Mero's script, or some-such).

Spoiler

//F1.7 Pits and Lava


//Used to determine if Link is on a Pit or Lava combo.
int OnPitCombo()
{
    int moving_platform[] = "Platform";
    int script_num = Game->GetFFCScript(moving_platform);
    int comboLoc = ComboAt(Link->X+8, Link->Y + Cond(BIG_LINK==0, 12, 8));
    for (int i = 1; i <= 32; i++)
    {
        ffc f = Screen->LoadFFC(i);
        if (f->Script == script_num && OnPlatform(f))
            return 0;
    }
    if(Screen->ComboT[comboLoc] != CT_HOLELAVA)
        return 0;
    else if(Screen->ComboI[comboLoc] == CF_PIT || Screen->ComboI[comboLoc] == CF_LAVA)
        return Screen->ComboI[comboLoc];
    else if(Screen->ComboF[comboLoc] == CF_PIT || Screen->ComboF[comboLoc] == CF_LAVA)
        return Screen->ComboF[comboLoc];
    else
        return 0;
}
 
//Snaps Link to the combo so he appears completely over pit and lava combos.
void SnaptoGrid()
{
    int x = Link->X;
    int y = Link->Y + Cond(BIG_LINK==0, 8, 0);
    int comboLoc = ComboAt(x, y);
 
    //X Axis
    if(Screen->ComboT[comboLoc] == CT_HOLELAVA && Cond(x % 16 == 0, true, Screen->ComboT[comboLoc+1] != CT_HOLELAVA))
        Link->X = ComboX(comboLoc);
    else if(Screen->ComboT[comboLoc+1] == CT_HOLELAVA && Cond(x % 16 == 0, true, Screen->ComboT[comboLoc] != CT_HOLELAVA))
        Link->X = ComboX(comboLoc+1);
    if(Cond(y % 16 == 0, false, Screen->ComboT[comboLoc+16] == CT_HOLELAVA) && Cond(x % 16 == 0, true, Screen->ComboT[comboLoc+17] != CT_HOLELAVA))
        Link->X = ComboX(comboLoc+16);
    else if(Cond(y % 16 == 0, false, Screen->ComboT[comboLoc+17] == CT_HOLELAVA) && Cond(x % 16 == 0, true, Screen->ComboT[comboLoc+16] != CT_HOLELAVA))
        Link->X = ComboX(comboLoc+17);
 
    //Y Axis
    if(Screen->ComboT[comboLoc] == CT_HOLELAVA && Cond(y % 16 == 0, true, Screen->ComboT[comboLoc+16] != CT_HOLELAVA))
        Link->Y = ComboY(comboLoc);
    else if(Screen->ComboT[comboLoc+16] == CT_HOLELAVA && Cond(y % 16 == 0, true, Screen->ComboT[comboLoc] != CT_HOLELAVA))
        Link->Y = ComboY(comboLoc+16);
    if(Cond(x % 16 == 0, false, Screen->ComboT[comboLoc+1] == CT_HOLELAVA) && Cond(y % 16 == 0, true, Screen->ComboT[comboLoc+17] != CT_HOLELAVA))
        Link->Y = ComboY(comboLoc+1);
    else if(Cond(x % 16 == 0, false, Screen->ComboT[comboLoc+17] == CT_HOLELAVA) && Cond(y % 16 == 0, true, Screen->ComboT[comboLoc+1] != CT_HOLELAVA))
        Link->Y = ComboY(comboLoc+17);
}

//Used to make Ex1/Ex2 switch items like L&R for A+B subscreens.
void LREx1Ex2ItemSwitch()
{
    if (Link->PressL && Link->Action != LA_SCROLLING)
    {
        Link->SelectBWeapon(DIR_LEFT);
    }
    if (Link->PressR && Link->Action != LA_SCROLLING)
    {
        Link->SelectBWeapon(DIR_RIGHT);
    }
    if (Link->PressEx1 && Link->Action != LA_SCROLLING)
    {
        Link->SelectAWeapon(DIR_LEFT);
    }
    if (Link->PressEx2 && Link->Action != LA_SCROLLING)
    {
        Link->SelectAWeapon(DIR_RIGHT);
    }
}

//Hole_Lava Init. Call before Waitdraw().
void InitHoleLava(){
    //Initialize variables used to store Link's strating position on Screen Init.
            PitsLava[HL_OLDDMAP] = Game->GetCurDMap();
            PitsLava[HL_OLDSCREEN] = Game->GetCurDMapScreen();
            PitsLava[HL_STARTX] = Link->X;
            PitsLava[HL_STARTY] = Link->Y;
            PitsLava[HL_STARTDIR] = Link->Dir;
 
            //Clear global variables used by Bottomless pits.
            PitsLava[HL_FALLING] = 0;
            PitsLava[HL_WARPING] = 0;
}

//Main Hole_Lava Rountine. Call after Waitdraw().
void RunHoleLava(){
    Update_HoleLava(PitsLava[HL_STARTX], PitsLava[HL_STARTY], PitsLava[HL_OLDDMAP], PitsLava[HL_OLDSCREEN], PitsLava[HL_STARTDIR]);
    if(Link->Z==0 && !PitsLava[HL_FALLING] && ( PitsLava[HL_OLDSCREEN] != Game->GetCurDMapScreen() || PitsLava[HL_OLDDMAP] != Game->GetCurDMap() ) && !OnPitCombo() )
    {
        PitsLava[HL_OLDDMAP] = Game->GetCurDMap();
        PitsLava[HL_OLDSCREEN] = Game->GetCurDMapScreen();
        PitsLava[HL_STARTX] = Link->X;
        PitsLava[HL_STARTY] = Link->Y;
        PitsLava[HL_STARTDIR] = Link->Dir;
    }
}

//Handles Pit Combo Functionality.
void Update_HoleLava(int x, int y, int dmap, int scr, int dir)
{
    lweapon hookshot = LoadLWeaponOf(LW_HOOKSHOT);
    if(hookshot->isValid()) return;
 
    if(PitsLava[HL_FALLING])
    {
        if(IsSideview()) Link->Jump=0;
        PitsLava[HL_FALLING]--;
        if(PitsLava[HL_FALLING] == 1)
        {
            int buffer[] = "Holelava";
            if(CountFFCsRunning(Game->GetFFCScript(buffer)))
            {
                ffc f = Screen->LoadFFC(FindFFCRunning(Game->GetFFCScript(buffer)));
                PitsLava[HL_WARPING] = 1;
                if(f->InitD[1]==0)
                {
                    f->InitD[6] = x;
                    f->InitD[7] = y;
                }
            }
            else
            {
                Link->X = x;
                Link->Y = y;
                Link->Dir = dir;
                Link->DrawXOffset -= Cond(Link->DrawXOffset < 0, -1000, 1000);
                Link->HitXOffset -= Cond(Link->HitXOffset < 0, -1000, 1000);
                Link->HP -= HOLELAVA_DAMAGE;
                Link->Action = LA_GOTHURTLAND;
                Link->HitDir = -1;
                Game->PlaySound(SFX_OUCH);
                if(Game->GetCurDMap()!=dmap || Game->GetCurDMapScreen()!=scr)
                Link->PitWarp(dmap, scr);
            }
            NoAction();
            Link->Action = LA_NONE;
        }
    }
    else if(Link->Z==0 && OnPitCombo() && !PitsLava[HL_WARPING])
    {
        Link->DrawXOffset += Cond(Link->DrawXOffset < 0, -1000, 1000);
        Link->HitXOffset += Cond(Link->HitXOffset < 0, -1000, 1000);
        int comboflag = OnPitCombo();
        SnaptoGrid();
        Game->PlaySound(Cond(comboflag == CF_PIT, SFX_LINK_FALL, SFX_LINK_LAVA));
        lweapon dummy = CreateLWeaponAt(LW_SCRIPT10, Link->X, Link->Y);
        dummy->UseSprite(Cond(comboflag == CF_PIT, WPS_LINK_FALL, WPS_LINK_LAVA));
        dummy->DeadState = dummy->NumFrames*dummy->ASpeed;
        dummy->DrawXOffset = 0;
        dummy->DrawYOffset = 0;
        PitsLava[HL_FALLING] = dummy->DeadState;
        NoAction();
        Link->Action = LA_NONE;
    }
}

//Handles MoscowModder's Gameboy Shield
void GameboyShield(){
    if( !ShieldOn() && ShieldItem() ){ //Enable shield when using dummy
        ShieldOn(true); //Set shield state to on
        if ( !Link->Item[ ShieldItem() ] )  Link->Item[ ShieldItem() ] = true; //Give the shield
        Game->PlaySound(SFX_GBSHIELD); //Play the sound
    }
    else if( ( ( ShieldButton() && !Link->InputA )||(!ShieldButton() && !Link->InputB)) //When button is released
            && ShieldOn() ){ //And shield is still on
        Link->Item[ ShieldItem() ]=false; //Remove shield
        ShieldItem(0); //Reset shield item variable
        ShieldOn(false); //Set shield state to off
    }
}

/////////////////////////////////////
/// Global Accessors  ///////////////
/// Setter and Getters for Arrays ///
/////////////////////////////////////

//Global setter/getter functions for shield script.

//Returns if shield is enabled.
bool ShieldOn(){
    return ( GB_Shield[SHIELD_ENABLED] != 0 );
}

//Sets if shield is enabled.
bool ShieldOn(bool state){
    if ( state ) GB_Shield[SHIELD_ENABLED] = 1;
    else GB_Shield[SHIELD_ENABLED] = 0;
}

//Returns if shield is on Button-A
bool ShieldButton(){
    return ( GB_Shield[SHIELD_BUTTON] != 0 );
}

//Sets if shield is on Button-A
bool ShieldButton(bool buttonA){
    if ( buttonA ) GB_Shield[SHIELD_BUTTON] = 1;
    else GB_Shield[SHIELD_BUTTON] = 0;
}

//Returns the item used as the shield in inventory.
int ShieldItem(){
    return GB_Shield[SHIELD_ITEM];
}

//Sets the inventory item to use as a shield.
void ShieldItem(int itm){
    GB_Shield[SHIELD_ITEM] = itm;
}


////////////////////
/// Item Scripts ///
////////////////////

//MoscowModder's Shield Script
//D0: "Real" shield item to give
item script gbshield{
    void run ( int shield ){
        ShieldItem(shield);
        if ( Link->PressB ) ShieldButton(false);
        else if ( Link->PressA ) ShieldButton(true);
    }
}

///////////////////
/// FFC Scripts ///
///////////////////

//Holes and Lava Main ffc
 
ffc script Holelava
{
    void run(int warp, bool position, int damage)
    {
        while(true)
        {
            while(!PitsLava[HL_WARPING]) Waitframe();
            if(warp > 0)
            {
                this->Data = CMB_AUTOWARP+warp-1;
                this->Flags[FFCF_CARRYOVER] = true;
                Waitframe();
                this->Data = FFCS_INVISIBLE_COMBO;
                this->Flags[FFCF_CARRYOVER] = false;
                Link->Z = Link->Y;
                PitsLava[HL_WARPING] = 0;
                Link->DrawXOffset -= Cond(Link->DrawXOffset < 0, -1000, 1000);
                Link->HitXOffset -= Cond(Link->HitXOffset < 0, -1000, 1000);
                Quit();
            }
            if(position)
            {
                Link->X = this->X;
                Link->Y = this->Y;
            }
            else
            {
                Link->X = this->InitD[6];
                Link->Y = this->InitD[7];
            }
            if(damage)
            {
                Link->HP -= damage;
                Link->Action = LA_GOTHURTLAND;
                Link->HitDir = -1;
                Game->PlaySound(SFX_OUCH);
            }
            Link->DrawXOffset -= Cond(Link->DrawXOffset < 0, -1000, 1000);
            Link->HitXOffset -= Cond(Link->HitXOffset < 0, -1000, 1000);
            PitsLava[HL_WARPING] = 0;
            Waitframe();
        }
    }
}

[Binx]

Because that line is in the global script, and "this" only refers to an FFC within an FFC script.

Then there needs to be a global variable that tells you if he's on the platform. I've tried every way possible of modifying the Update_Holelava function and OnPitCombo functions (trying to get rafting to work, even tried to make a scripted raft for it), and nothing worked until I expanded the Link->Action check in the global. I dunno *why* that is, but as long as there's nothing in the global to protect platforms from pits, it won't work.

[Lejes]

My method is to check for an FFC running the platform script, then use the existing OnPlatform function to see if Link is standing on top of it. I explicitly know this works because I went to the trouble of compiling a test quest for it. I don't know how EJSnowden set up his own quest, and he's only posted snippets of his full script, so I can't know what else he's doing.

[EJSnowden]

What I posted is pretty much all the relevant script work, the rest is a sideview ladder, power bracelet, and sideview, using the other global script slots. Platforms are handled by global flags, as are pits. In the script above, there's no check for platforms.

 

I'm considering tabling this until I'm competent enough with zscript to write in my own code. I can just use water as pits for now.

[Lejes]

I meant that I would like to see the entirety of the script so I can actually compile it. The segments you've got there are missing all of the constants etc. I'm expecting this to be some kind of ZQuest error, like not actually assigning the Platform script to the FFC in the room, because what I've got doesn't look fundamentally different from what's in your post and it works.