23 replies to this topic

[cavthena]

I get that much, what I meant was can both shallow water and tall grass be combined into one script?

[MoscowModder]

Here you go. I just copied/pasted the script, changed some variable names, and added the sound effect ID and frequency to the global variables.

Script

CODE

import "std.zh"

const int splashFreq = 10; //Number of frames between splash SFX
const int grassFreq = 10; //Number of frames between grass SFX
const int grassSFX = 0; //ID of the grass SFX

global script waterSplash{
    void run(){
        int splashTimer = splashFreq;
        int grassTimer = grassFreq;
        while(true){
            //Shallow water SFX
            if( Screen->ComboT[ComboAt(Link->X+7,Link->Y+15)] == CT_SHALLOWWATER
            && Link->Action==LA_WALKING
            ){
                if( splashTimer >= splashFreq ){
                    Game->PlaySound(SFX_SPLASH);
                    splashTimer = 0;
                }
                splashTimer++;
            }
            else splashTimer = splashFreq;
            
            //Tall grass SFX
            if( Screen->ComboT[ComboAt(Link->X+7,Link->Y+15)] == CT_TALLGRASS
            && Link->Action==LA_WALKING
            ){
                if( grassTimer >= grassFreq ){
                    Game->PlaySound(grassSFX);
                    grassTimer = 0;
                }
                grassTimer++;
            }
            else grassTimer = grassFreq;
            Waitframe();
        }
    }
}

[Xenix]

i managed to get the script working with a little help from Zephino. I had to take the global part and make it a void ShallowWater() outside of the global part so it could have a separate Waitframe(); and called it after the while(true){ with ShallowWater();. It works great! Thanks!

[LinktheMaster]

About enhanced music, unfortunately it's not modifiable via scripting.

[Saffith]

I haven't committed it yet (have to be sure it isn't buggy first), but I just added in Game->PlayEnhancedMusic(). Like Game->PlayMIDI(), though, it only lasts until you change screens, so it might not be what you need here.

[Xenix]

That actually is exactly what I need! Great Saffith! Thanks!

[Saffith]

Might as well note here that I also added Game->SetDMapEnhancedMusic, which will make it carry over between screens.

[Xenix]

That's great Saffith! I can't wait for the RC3 release!

[Christian]

Might as well note here that I also added Game->SetDMapEnhancedMusic, which will make it carry over between screens.

I love you. No more horrible MIDI! <3