290 replies to this topic

[Saffith]

I also have a minor fix to roll into this update, that I'll get to you in the next few days. I'll send it to you by PM here, if you prefer that, or I'll just post it to the thread here.

If you've done the work already, the best thing to do would be to submit a pull request.

[Timelord]

If you've done the work already, the best thing to do would be to submit a pull request.

I didn't know that you were basing 2.50.3 off the stuff on Git. In fact, I thought that you couldn't, because of all the changes, and that files such as ffcscript.cpp would need to be based on the prior versions, going into this.

Is your 2.50.3 patch release based entirely on the repo?

The newer files with additions from Gleeok, and me, change the ZASM bytecode. This singular fix, does not.

Edited by ZoriaRPG, 01 August 2016 - 11:54 PM.

[Saffith]

There's a separate branch for it.
https://github.com/A...sic/tree/2.50.x

[Timelord]

There's a separate branch for it.https://github.com/A...sic/tree/2.50.x

Oh, gorgeous. I wasn't aware that you added it. Was there an announcement that I missed?

[Ben]

Quick question. The in-game Help, I realize, is outdated, but it mentions you can flip entire screens or even maps using hotkeys. This doesn't appear to work anymore. Could that functionality be restored?

[Saffith]

It was just too buggy to keep. Several people reported that their warp destinations were being corrupted, which eventually turned out to be because they had accidentally reversed a map and then undone it. I didn't see a reasonable way to fix it, so I removed it instead. I could take another look at it, but it's probably more trouble than it's worth.

Oh, gorgeous. I wasn't aware that you added it. Was there an announcement that I missed?

No, it just kind of happened.

[SyrianBallaS]

Might be easier to post a video. At the time of writing this video is still processing.

Don't mind the thumbnail, I just put this together fast.

 

 

Edited by SyrianBallaS, 03 August 2016 - 12:44 AM.

[Timelord]

It was just too buggy to keep. Several people reported that their warp destinations were being corrupted, which eventually turned out to be because they had accidentally reversed a map and then undone it. I didn't see a reasonable way to fix it, so I removed it instead. I could take another look at it, but it's probably more trouble than it's worth.No, it just kind of happened.

Hmm... why not just bypass updating the warps? require a second stage, or manual changing.

[Saffith]

Maybe. I'll look at it. It's still a lot of work for something of very limited usefulness.
 

Might be easier to post a video.

Huh. What does allegro.log say?
Can you run it in standalone mode? That would be something like
zelda-w -standalone Quest.qst -savefile Quest.sav

[SyrianBallaS]

allegro.log doesn't say anything useful but it stops prematurely, this is launching from ZCL and then selecting a quest.

 

Loading Quest: C:\Users\Samer\Zelda Classic\Zelda Classic\..\Quests\Quest.qst...

 

Decrypting...okay.

Opening...okay.

Reading Header...okay.

Made in ZQuest 250 Beta 24

Reading Rules...okay.

Reading Strings...okay.

Reading Doors...okay.

Reading DMaps...okay.

Reading Misc. Data...okay.

Reading Misc. Colors...okay.

Reading Game Icons...okay.

Reading Items...okay.

Reading Weapons...okay. <-- Stops here

 

Surprisingly it worked in standalone mode w/ zero compatibility settings, it would crash with compatibility settings, in my case the command was 

zelda-w -standalone "%USERPROFILE%\Zelda Classic\Quests\Quest.qst" -savefile Quest.sav

 

Another weird thing I noticed is that it's making these 14 MB tmp files but they persist. Is that because of the crashing?

 

I guess I'll just make batch files for quests that crash.

Edited by SyrianBallaS, 04 August 2016 - 11:18 PM.

[Saffith]

It looks like it's crashing trying to read the maps. Could you try this for me?
https://www.dropbox....elda-w.exe?dl=0
That'll write a bunch of numbers to allegro.log, and hopefully it will crash somewhere in the middle of them. Could you show me the last bit? Specifically, I'm looking for the last "Screen xxx" line and the last number after that.
Also, could you make sure the version of the quest file you have matches the current version in the database, and send me the one you're using if not?

Yes, the .tmp files would normally be cleaned up when it finished loading. You can just delete them.

[Ben]

I've made a "bomb expansion" item that is a bomb bag that is supposed to increase my bomb count by 2. However it appears that the minimum number that can be increased is 5?

[coolgamer012345]

I've made a "bomb expansion" item that is a bomb bag that is supposed to increase my bomb count by 2. However it appears that the minimum number that can be increased is 5?

Do you have "Increase Amount" and "Increase Counter Max" swapped (as in, did you try to make it increase the amount of bombs link has by 5, but the max amount by 2)?

[Ben]

Do you have "Increase Amount" and "Increase Counter Max" swapped (as in, did you try to make it increase the amount of bombs link has by 5, but the max amount by 2)?

 

Yes. That is my problem. I completely zoned out and forgot about the Pickup tab entirely.

[SyrianBallaS]

It looks like it's crashing trying to read the maps. Could you try this for me?
https://www.dropbox....elda-w.exe?dl=0
That'll write a bunch of numbers to allegro.log, and hopefully it will crash somewhere in the middle of them. Could you show me the last bit? Specifically, I'm looking for the last "Screen xxx" line and the last number after that.
Also, could you make sure the version of the quest file you have matches the current version in the database, and send me the one you're using if not?

Yes, the .tmp files would normally be cleaned up when it finished loading. You can just delete them.

The build you gave me didn't make it crash.