645 replies to this topic

[SpacemanDan]

Did the way enemy flickering worked change any? I had it set before the update and it worked fine, but with the new update, all ghost enemies flicker regardless of being hit or not. O_o

[Saffith]

D'oh. Yeah, there was a little flashing bug. I fixed that, but I guess I forgot to recheck flickering.
Anyway, simple enough. It's fixed now.

Edit: Nope, I rushed it and screwed it up again. Fantastic.
Now it's fixed. Or you can just fix it in place. update.zh, lines 159-162:

CODE

        // Not flickering
        if((__ghzhData[__GH_GLOBAL_FLAGS]&__GHGF_FLICKER)==0 ||
           (GH_ENEMIES_FLICKER==0 && (ghost->MiscFlags&10000000b)==0) ||
           (GH_ENEMIES_FLICKER!=0 && __Ghost_FlashCounter==0 && (ghost->MiscFlags&10000000b)==0))

Clearly, I should've just made that a separate function, but that'll do for now...

[Moosh]

I'm trying to use GHF_WATER_ONLY and the enemy is going on land anyways. Am I doing something wrong or is the flag bugged?

[Saffith]

I'm not seeing a problem with it. Can you show me what you've got?

[Moosh]

CODE

ffc script Water_Tektite{
    void run(int enemyid){
        npc ghost=Ghost_InitAutoGhost(this, enemyid, GHF_WATER_ONLY|GHF_KNOCKBACK|GHF_REDUCED_KNOCKBACK|GHF_STUN|GHF_CLOCK);
        int combo=ghost->Attributes[10];
        Ghost_Transform(this, ghost, combo, ghost->CSet, 1, 1);
        ghost->OriginalTile=GH_BLANK_TILE;
        while(true){
            Ghost_Waitframes(this, ghost, true, true, 60);
            int angle=Angle(Ghost_X, Ghost_Y, Link->X, Link->Y)+Rand(-90, 90);
            for(int i=0; i<30; i++){
                Ghost_MoveAtAngle(angle, ghost->Step/100, 0);
                Ghost_Waitframe(this, ghost, true, true);
            }
        }
    }
}

Here's the script. Very basic enemy, don't see anything in particular that could have caused it. I know you updated ghost for the final build of 2.5 which I haven't upgraded to for reasons (basically I don't want more than one ZC 2.5 build on my computer if I can help it and so I'm waiting until I finish a couple quests before I update). Could that be my problem? Were there bugs with this flag prior to that update?

[Saffith]

CODE

        npc ghost=Ghost_InitAutoGhost(this, enemyid, GHF_WATER_ONLY|GHF_KNOCKBACK|GHF_REDUCED_KNOCKBACK|GHF_STUN|GHF_CLOCK);

That's the problem. I ran out of bits for flags, so you can't OR them together anymore. You have to do them one by one.

CODE

        npc ghost=Ghost_InitAutoGhost(this, enemyid);
        Ghost_SetFlag(GHF_WATER_ONLY);
        Ghost_SetFlag(GHF_KNOCKBACK);
        Ghost_SetFlag(GHF_REDUCED_KNOCKBACK);
        Ghost_SetFlag(GHF_STUN);
        Ghost_SetFlag(GHF_CLOCK);

[Moosh]

CODE

        npc ghost=Ghost_InitAutoGhost(this, enemyid, GHF_WATER_ONLY|GHF_KNOCKBACK|GHF_REDUCED_KNOCKBACK|GHF_STUN|GHF_CLOCK);

That's the problem. I ran out of bits for flags, so you can't OR them together anymore. You have to do them one by one.

CODE

        npc ghost=Ghost_InitAutoGhost(this, enemyid);
        Ghost_SetFlag(GHF_WATER_ONLY);
        Ghost_SetFlag(GHF_KNOCKBACK);
        Ghost_SetFlag(GHF_REDUCED_KNOCKBACK);
        Ghost_SetFlag(GHF_STUN);
        Ghost_SetFlag(GHF_CLOCK);

I feel dumb now. By ran out of bits do you mean I can't OR them together at all or that there's a cap or how many I can or together and I exceeded it?

[Saffith]

It depends on the specific flags you use, but, strictly speaking, you shouldn't use any of them that way. The option's only still available for the sake of backward compatibility.

[Orithan]

I think any set of flags in ZC can have a maximum of 16 bits, which produces a value of up to 65535. Saffith must have gone over this limit and now we must set them individually because of this.

[Moosh]

Updated ZC, updated ghost, error message, mom's spaghetti.

PASS 1: PARSING
PASS 2: PREPROCESSING
PASS 3: BUILDING SYMBOL TABLES
TMP, LINE 239: ERROR S09: VARIABLE _GHI_IN_USE IS UNDECLARED.
TMP, LINE 239: ERROR S10: FUNCTION GHOST_CLEARATTACHEDFFCS IS UNDECLARED.

Tried importing ghost_legacy to see if that would fix the problem, still returning the same error. What am I doing wrong?

Edited by Moosh, 24 December 2012 - 03:44 PM.

[Mero]

Did you export ghost_zh and ghost.zh to the same folder as ZQuest?

[Moosh]

Yes I did. I've tried putting ghost.zh in the same folder as the rest and changing some things and it appears it's having trouble importing update.zh.

Edit: D'oh! I see what my problem was. I had modified versions of stuff from the old in my actual script buffer. Well shit.

Edit 2: Okay, the update broke all of my autoghost enemies. All of them. I can't help but feel a little grumpy about that since it appears you went to great lengths to maintain backwards compatibility and I have absolutely no clue what's wrong.

Edit 3: Edited global script and now autoghost enemies are appearing at least, but none of them do anything after spawning nor to they visibly take damage or play any death effects.

Edited by Moosh, 24 December 2012 - 10:24 PM.

[SpacemanDan]

Did MoveAtAngle break or is there a certain way to set it up? I ask because when I try to use it, the enemy in question will always move right. O_o

[Saffith]

Sorry. Been failing to keep up with the thread, obviously.

Edit 3: Edited global script and now autoghost enemies are appearing at least, but none of them do anything after spawning nor to they visibly take damage or play any death effects.

Did you get this worked out?
Were you using an existing save? That's all I can think of, offhand.

Did MoveAtAngle break or is there a certain way to set it up? I ask because when I try to use it, the enemy in question will always move right. O_o

Degrees/radians issue, probably. It's degrees you want, in this case.
I do wish ZScript were a bit more consistent about that...

[SpacemanDan]

I got it working. I believe that was the problem. XD Thanks for the help.