645 replies to this topic

[Mero]

Why not just take two arguments for flags and group terrain flags together and all other flags in the other group.

[Saffith]

That would work for now, but it's likely I'd run into the same problem again later on. Further division would make it increasingly difficult to maintain compatibility with existing scripts and would pretty quickly negate the benefit of doing it that way in the first place.

[Saffith]

Found bugs!

UpdateEWeapon():

CODE

    // If Link's holding up an item, don't do anything
    if(Link->Action==LA_HOLD1LAND || Link->Action==LA_HOLD2LAND ||
       Link->Action==LA_HOLD1WATER || Link->Action==LA_HOLD2WATER)
        return;

    // If this is a dummy, or if it's not a ghost.zh weapon, don't do anything
    if((wpn->Misc[__EWI_FLAGS]&__EWFI_IS_GHZH_EWPN)==0 || (wpn->Misc[__EWI_FLAGS]&__EWFI_DUMMY)!=0)
        return;

The first 4 comparisons should be checked only once, not once per weapon. Also the next 4 should be inlined to avoid the function since it's 99% likely that they are not ghost created. ( I would inline everything in UpdateEWeapons() since it's required to call once per frame anyway you don't need to ever update only one weapon. Optimize it! )

Also the THROW_BOUNCE thing is neat. Thanks for scripting the math for that already...because I really did not want to.

You got the wrong thread. I'd move your post, but apparently I don't have that ability.

Anyway, yeah, I guess I'll do that. I made it that way since I wanted to have to option to call UpdateEWeapon on the individual weapons you want handled and skip the rest, but, now that I think about it, neither check is really necessary in that case.

[MoscowModder]

This is odd. I made an autoghost enemy, and I tried setting its combo (misc attribute 11) to both GH_INVISIBLE_COMBO and __GH_INVISIBLE_ALT (-1) and still the enemy is invisible. I even set it to a combo that looks like the enemy and it used a different combo near it in the combo sheet. I changed the combo, hoping to make up for the offset... but it did a different nearby combo.

WHAT IS UP WITH THIS?! Everything else in the script works besides showing the enemy.

Script

CODE

ffc script laserSentry{
    //void run ( int rotSpeed, int HP, int damage, int radius, int delay, int cooldown ){
    void run ( int ID ){
        npc ghost = Ghost_InitAutoGhost(this, ID, GHF_SET_DIRECTION | GHF_4WAY); //Initialize ghost NPC
        int rotSpeed = ghost->Attributes[LS_ATTRIB_ROTSPEED]; //Load its attributes
        int radius = ghost->Attributes[LS_ATTRIB_RADIUS];
        int delay = ghost->Attributes[LS_ATTRIB_DELAY];
        int cooldown = ghost->Attributes[LS_ATTRIB_COOLDOWN];
        int color = ghost->Attributes[LS_ATTRIB_LASERCOLOR];
        int angle;
        while(ghost->isValid()){
            Screen->Arc(3, ghost->X+8, ghost->Y+8, radius , -1*angle , -1*angle+1, color, 1, 0, 0, 0, false,false, 128); //Draw laser pointer
            if ( DistanceLink(ghost->X+8, ghost->Y+8) <= radius //If Link is within its radius
            && AnglePos(ghost->X, ghost->Y, Link->X, Link->Y) >= angle //And between the two angles (new and old)
            && AnglePos(ghost->X, ghost->Y, Link->X, Link->Y) <= angle+rotSpeed
            ){
                Game->PlaySound(SFX_ALARM);
                int x = Link->X+8; //Save Link's pos
                int y = Link->Y+8;
                Waitframes(delay); //Wait before firing
                fireLaserLine( ghost->X+8, ghost->Y+8, 600, ghost->WeaponDamage, x, y ); //Shoot where Link was
                Waitframes(cooldown); //Wait before resumed operation
            }
            angle = (angle+rotSpeed) % 360;
            Ghost_Waitframe(this, ghost, true, true);
        }
    }
}

[Saffith]

You've got regular Waitframes in there. Does replacing those fix it?

[Gleeok]

You got the wrong thread. I'd move your post, but apparently I don't have that ability.

Whoops, sorry 'bout that! Same great cookie crunch, half the monkey ball extract. ...But yeah, everything else is meh, but the eweapons need to be optimized aggressively. After about 200 bullets you get slowdown.

I also misread your enemy->Misc bit you wrote. It uses Misc 15 by default for enemies but for some reason I thought it used all of them but 15. I don't know why I thought that. :\

[Moosh]

Whoops, sorry 'bout that! Same great cookie crunch, half the monkey ball extract. ...But yeah, everything else is meh, but the eweapons need to be optimized aggressively. After about 200 bullets you get slowdown.

I also misread your enemy->Misc bit you wrote. It uses Misc 15 by default for enemies but for some reason I thought it used all of them but 15. I don't know why I thought that. :\

200 eweapons? When would you ever need that many?

Also SHOOT I've also been using Misc[15]!

[MoscowModder]

You've got regular Waitframes in there. Does replacing those fix it?

Nope. No better.

[Saffith]

Hm, I'm seeing it with other things, so it's definitely a failure on my part. I swear I tested that... Must not have been with the final version.
I don't see what the problem is yet, though. I'll update it when I find it.

Also SHOOT I've also been using Misc[15]!

That's npc->Misc, mind. Depending on what you're doing with it, using it yourself may not cause problems, but it's better not to risk it. You can change which element is used by setting __GHI_IN_USE.

[Saffith]

All right, should be fixed now. Sorry to take so long.

[MoscowModder]

Thanks, it works!

[Moosh]

How can I detect if a ghosted enemy is able to move x steps at y angle with z pixels of imprecision? I tried Ghost_CanMove(), but it didn't work...

[Moosh]

So I've noticed that Ghost.zh doesn't interact very kindly with sideview gravity...Mainly I can't get a floating enemy to move upwards...Any help?

[Saffith]

Set GHF_NO_FALL.
I still need to do some work on the movement functions. I just haven't been good about actually doing stuff lately...

[Saffith]

Another small update to fix a couple of bugs I ran into recently. Also, I added a new option for misc. attribute 11: __GH_INVISIBLE_EXTEND (-2 by default), which will set up an FFC with the invisible combo but still set npc->Extend to 3.