Jump to content

Photo

ZC v2.10 Quests - No Secret Sounds, Money, Lost Woods Side Warp


  • Please log in to reply
12 replies to this topic

#1 obake-san

obake-san

    Experienced Forumer

  • Members

Posted 26 February 2023 - 12:50 PM

Hopefully reporting three in one topic is fine. These are each about backwards compatibility with old v2.10 quests. These were found in Link's Decision 2. They work as intended in ZC v2.53, but not in ZC v2.55. I'm using alpha 112 build 13th Feb 2023 in the videos. The first two are also in earlier v2.10 quests, but the third has to be pretty rarely used so I don't know.

 

First is the no secret sounds. The ZC v2.10 screen flag for No Secret Sounds doesn't stop the secret sound from playing in v2.55. The first instance is almost immediately when you start the quest. At the very introduction when you pick up your sword, it triggers a combo change that adds direct warps beneath you, so you pick up your sword and then suddenly your map appears and the music starts. Now you hear the secret sound before you warp to the screen with the map and the music. There are lots of other examples, but the easiest is the big statues in the Mountain, where a switch lowers them. It's mostly just annoying, and sometimes you hear multiple in rapid succession.
 
Second is the secret money caves. You should go in, read some text, collect the money, and then it's basically an empty room after that. But for some reason, collecting the money isn't permanent. It doesn't happen when you have a cave/stairs that leads to the zelda1 screen 80. But when the cave leads to an actual screen, you can do it over and over. to see if I could figure out the cause, I tried changing the warp type from insta-warp to entrance, changing the room dmap from cave to dungeon to bs overworld, changing the level from 1 to 19 and even 0 just for fun.
 
Third is an uncommon maze path issue, not so much a bug as a change. There is a post-game dungeon that is a series of lost woods maze screens. When playing my quest in v2.53, if my maze path solution is west-east-north-east and east is a side warp, it doesn't go through the side warp until the maze path is solved. In v2.55, it goes through the side warp as soon as you go east, ignoring the maze path. Fortunately, the puzzle solution still works. But it does make a wrong step much more confusing. That's not a great description of the puzzle, but point being the precedence between solving the maze path and triggering the side warp is reversed.
 
Videos often help, so I have a one minute video of each. https://ufile.io/f/neq31  The link expires after a few weeks. Let me know if there is anything else I can do to help. Thanks.

  • Twilight Knight likes this

#2 connor.clark

connor.clark

    Junior

  • ZC Developers

Posted 26 February 2023 - 09:31 PM

This is amazing, thanks for the reports!

I bisected for the first issue (ignoring No Secret Sounds), found the first release it broke in. Here are my notes.
 

```sh
python scripts/bisect_builds.py --bad 2.55-alpha-112 --good 2.55-alpha-108 --token $GH_PAT -c '%zc -test /Users/connorclark/code/ZeldaClassic-secondary/build/Release/Links.Decision.2.qst 62 120'
```
 
```
GOOD    nightly-2022-09-10-2
BAD     nightly-2022-09-10-3
 
You are probably looking for a change made after nightly-2022-09-10-2 (known good), but no later than nightly-2022-09-10-3 (first known bad).
```
 
I'm stepping away for a bit, but if you can provide a dmap and screen for the other two issues, it will help me reproduce.


#3 obake-san

obake-san

    Experienced Forumer

  • Members

Posted 27 February 2023 - 12:35 AM

secret money - a burnable bush at dmap 1 screen 56 for the first one in progression. If you save while you're at that screen, your continue point is screen 77, so it's just north north west to get back there quickly.

side warp - dmap 113 screen 43, don't go south. 



#4 obake-san

obake-san

    Experienced Forumer

  • Members

Posted 27 February 2023 - 11:54 PM

I came across a fourth issue. Keese and bats are unable to fly over water. dmap 182 screens 1A and 19 are an example of each. I don't have examples for these, but peahats and pols voices can't cross water either.



#5 Emily

Emily

    Scripter / Dev

  • ZC Developers

Posted 28 February 2023 - 03:18 AM

 

This is amazing, thanks for the reports!

I bisected for the first issue (ignoring No Secret Sounds), found the first release it broke in. Here are my notes.
 

```sh
python scripts/bisect_builds.py --bad 2.55-alpha-112 --good 2.55-alpha-108 --token $GH_PAT -c '%zc -test /Users/connorclark/code/ZeldaClassic-secondary/build/Release/Links.Decision.2.qst 62 120'
```
 
```
GOOD    nightly-2022-09-10-2
BAD     nightly-2022-09-10-3
 
You are probably looking for a change made after nightly-2022-09-10-2 (known good), but no later than nightly-2022-09-10-3 (first known bad).
```
 
I'm stepping away for a bit, but if you can provide a dmap and screen for the other two issues, it will help me reproduce.

 

...oh for *fucks sake*, that's not a commit I like seeing here....



#6 connor.clark

connor.clark

    Junior

  • ZC Developers

Posted 01 March 2023 - 10:12 PM

What is the cheat code for this quest?



#7 obake-san

obake-san

    Experienced Forumer

  • Members

Posted 02 March 2023 - 06:00 PM

Oh, I had assumed you had a dev way to do it already. level 4 cheats with this quest is


Edited by obake-san, 07 March 2023 - 06:31 PM.

  • Magi_Hero likes this

#8 connor.clark

connor.clark

    Junior

  • ZC Developers

Posted 03 March 2023 - 12:07 AM

We do, but not for older builds AFAIK.
 

```
=== secret money room
 
1 86
 
GOOD    2.55-alpha-99
BAD     2.55-alpha-100
 
You are probably looking for a change made after 2.55-alpha-99 (known good), but no later than 2.55-alpha-100 (first known bad).
 
=== maze side warp
 
113 77 (0x43)
 
bad 2.55-alpha-83
good ???
 
=== keese won't fly over water
 
182 26 (0x1A)
 
GOOD    2.55-alpha-92
BAD     2.55-alpha-97
 
You are probably looking for a change made after 2.55-alpha-92 (known good), but no later than 2.55-alpha-97 (first known bad).
```
 
Secret money room bug happened between A99/100.
Maze side warp bug broke before A83, I would need help connecting older test builds to commits on the main branch to go further.
Keese not flying over water broke between A92/97. Huge range, I could not find any alphas 93-96.


#9 Emily

Emily

    Scripter / Dev

  • ZC Developers

Posted 03 March 2023 - 02:41 AM

 

We do, but not for older builds AFAIK.

You could just open the quest in a current build, and check the cheat code yourself, lol



#10 connor.clark

connor.clark

    Junior

  • ZC Developers

Posted 04 March 2023 - 12:25 AM

The flying-over-water issue bisects to:

 

```

commit 53c170f1d6ade2926b6d3e4776e6dbeee0561de2
Author: DimiPZC
Date:   Mon Apr 5 02:34:05 2021 -0400
 
    Added npc moveflags "Can Walk on Water" and "Can Drown in Water".

```



#11 connor.clark

connor.clark

    Junior

  • ZC Developers

Posted 04 March 2023 - 01:39 AM

Secret money room bug:

 

```

commit 6711a65ca18270ad009684bce515ed51ebf1a7ea
Author: DimiPZC
Date:   Fri Nov 5 10:19:21 2021 -0400
 
    Initial fix of reimplementing how guys and special items used to work when compat rules are enabled.

```



#12 connor.clark

connor.clark

    Junior

  • ZC Developers

Posted 04 March 2023 - 06:24 PM

deleted



#13 Deedee

Deedee

    Bug Frog Dragon Girl

  • Moderators
  • Real Name:Deedee
  • Pronouns:She / Her, They / Them
  • Location:Canada

Posted 23 December 2023 - 09:05 AM

The secret money thing was a bug in 2.10 where specifially secret money guys, door repair guys, and potion or heart container guys didn't check to see if they had been gotten before if they were not in a sreen 80 cave. Spoilered below is the relevantcode snippet from the 2.10 source we have.

Boring 2.10 source code


At various points in the 2.50 betas, these were individually fixed. However, some people in 2.10 and early 2.50 betas relied on this behavior, such as to have door repairs that always respawned to have "no money beyond this point" (as seen in Liberation of Hyrule), and while I had no evidence that the other two were used, I could easily see someone relying on the secret money for things like respawning minigame rewards or a poor-man's arrow refill; so I added compatability for these quirks for the versions where these bugs were active.

I booted up Link's Decision 2 in 2.10 and went to two locations; the burnable bush on screen 1:56, and the open stairway on 1:1C. The burnable bush on screen 56 is a Special Item room that gives you the 20 rupee item, and it doesn't respawn; neither in 2.10 nor in 2.55 (which I also tested). However, the open stairway on 1:1C always respawned, both in 2.10 (the version the quest was saved in) and in 2.55. In other words, 2.55 is emulating the behavior of the version the quest was saved in pretty accurately.

I'm not entirely sure what the solution here is; you could upgrade the quest to a newer version like 2.50 or 2.55 to have it not try to apply these bug fixes, but that would presumably lose the novelty of your quest being a 2.10 quest. You could have it be a secret item instead and have them give out 50 rupees, but if the 41 specifically is a reference then you'd lose out on that. 




1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users