26 replies to this topic

[MoscowModder]

But even doing all that won't stop non-scripted FFC movement. To deal with that, you'd have to use the global script to prevent it, possibly by remembering each one's position and restoring it each frame.

Or you could place a combo/FFC with a "Freeze all movement" combo type.

Right?

[Saffith]

Do you mean "Screen Freeze (FFCs Only)"? You can't do that, because it would also freeze the script you're trying to run.

[Saffith]

Updated. Just two small changes:
- Invalid script numbers now fail correctly, so you can use Game->GetFFCScript() without validating the result
- The argument array no longer needs to be 8 elements

[Nightmeres]

cant seam to import this file do i need to compile it?

[Saffith]

It should go in the ZC program directory, the same place as std.zh.

[Nightmeres]

thankyou, it works now

[Saffith]

Updated. It will now make sure not to grab changers.

[Mero]

I love you...

[ywkls]

This is something that I noted was happening with one of my scripts whenever I used the functions RunFFCScript or RunFFCScriptOrQuit.

Whenever I used an item script to launch an ffc, if that ffc's script had settings to its TileHeight or TileWidth; there was a chance that the next item script to launch an ffc after the previous ffc no longer existed would retain those values.

The simplest solution that I found to fix this was to do the folllowing.

int RunFFCScript(int scriptNum, float args){
    // Invalid script
    if(scriptNum<0 || scriptNum>511)
        return 0;
    
    ffc theFFC;
    
    // Find an FFC not already in use
    for(int i=FFCS_MIN_FFC; i<=FFCS_MAX_FFC; i++){
        theFFC=Screen->LoadFFC(i);
        
        if(theFFC->Script!=0 ||
         (theFFC->Data!=0 && theFFC->Data!=FFCS_INVISIBLE_COMBO) ||
         theFFC->Flags[FFCF_CHANGER])
            continue;
        
        // Found an unused one; set it up
        theFFC->Data=FFCS_INVISIBLE_COMBO;
        //Reset the ffc's tile width and height to prevent carryover from earlier scripts.
	theFFC->TileWidth = 1;
	theFFC->TileHeight = 1;
        theFFC->Script=scriptNum;
        
        if(args!=NULL){
            for(int j=Min(SizeOfArray(args), 8)-1; j>=0; j--)
                theFFC->InitD[j]=args[j];
        }
        
        return i;
    }
    
    // No FFCs available
    return 0;
}

From what I can tell, making this change prevents the bug in question from happening.

Edited by ywkls, 20 December 2016 - 02:44 PM.

[Saffith]

I don't know if I'd consider it a bug, exactly, but there shouldn't be any harm in resetting the FFC's data. I'll do that next update.

[Timelord]

There is another issue, and this one is also subtle.
 
The *Running() functions do not check to see if the ffc is in a state where it can run script code. It returns if a script is assigned, but that is all.
 
A basic hypothetical situation:
 
You have a global script that assigns ffc running conditions, halting them by setting their data = 0, and resuming them by setting their data = 1;
You want to use CountFFCsRunning() to determine how many instances of that script are running.
You have three ffcs with that script assigned, with data set to 1; and 4 with data set to 0.
The desired result of CountFFCsRunning(), would be 3, but, it returns 7.
 
I do not know if anything relies on those functions to return NumFFCsWithScript(int s), but, this is what I would do for these checks:
 
 

int CountFFCsRunning(int scriptNum)
{
	// Invalid script
	if(scriptNum<0 || scriptNum>511)
		return 0;
	
	ffc f;
	int numFFCs=0;
    
	for(int i=1; i<=32; i++)
	{
		f=Screen->LoadFFC(i);
		if(f->Script==scriptNum)
		{
			if ( f->Data )
			{
				if ( !f->Flags[FFCF_ETHEREAL] )
				{
					numFFCs++;
				}		
			}
		}
	}
	return numFFCs;
}
 

 

Edit: A better alternative, is probably an extra definition with a boolean argument, such as CountFFCsRunning(int script, bool only_active), as that would not break any scripts that depend on this quirk.

[Saffith]

Eh, maybe. Thing is, Data==0 doesn't imply that the script isn't running. It won't start running, but it will continue once it's started. There's no way for another script to tell the difference.