59 replies to this topic

[Jared]

I just set the dummy shield to an old item on a default subscreen. The dummy shield doesn't show up at all.

Edited by Jared, 21 May 2012 - 03:38 PM.

[MoscowModder]

That's not a problem with the script since it shouldn't give or take the item. Try using Link Data to see if you actually have the shield.

[SUCCESSOR]

Jared, What Class is it? If it shares a Class with another item that has a higher level it won't show up. Thats all i can think of.

I just tried it with all the shields. My "Dummy lShields" showed up on screen but didn't seem to trigger the script. I set the constants.

Edited by SUCCESSOR, 21 May 2012 - 06:32 PM.

[Jared]

MM, I pick up the item from the ground. I obviously pick it up. I HAVE the item.

And Successor, I'm using a new, blank quest file to test this. So that can't be the problem.

[tox_von]

Shouldnt there be a rule that all scripts come with functioning examples and instructions like the Joe123 site here it would be way easier to get them working if there was. This site setup is perfect for scripts.

ZC REALM

Edited by tox_von, 21 May 2012 - 07:58 PM.

[MoscowModder]

Functioning examples and instructions are great for database entries - this is something I just wrote up/modified for a quick request.

Edited and tested! I removed a lot of unnecessary code (since you didn't want strafing), so be sure to clear it out in your copy. Instead of six constants for six shields, use the new item script to determine the shield item that will be given (D0 argument).

CODE

//import "std.zh"

const int SFX_GBSHIELD = 17; //Shield active SFX

int shieldItem; //Shield item to give (set by item script, reset each frame)
bool shieldButton; //False = B, True = A

global script slot_2{
    void run(){
    //Initializations
    bool shieldOn;
        
        while(true){
            if( !shieldOn && shieldItem ){ //Enable shield when using dummy
                shieldOn=true; //Set shield state to on
                Link->Item[shieldItem]=true; //Give the shield
                Game->PlaySound(SFX_GBSHIELD); //Play the sound
            }
            else if( ( (shieldButton && !Link->InputA)||(!shieldButton && !Link->InputB)) //When button is released
            && shieldOn){ //And shield is still on
                Link->Item[shieldItem]=false;
                shieldItem = 0;
                shieldOn = false;
            }

            Waitframe();
        }                 // end while
    }                  //end void run
}

//D0: "Real" shield item to give
item script gbshield{
    void run ( int shield ){
        shieldItem = shield;
        if ( Link->PressB ) shieldButton = false;
        else if ( Link->PressA ) shieldButton = true;
    }
}

[SUCCESSOR]

Works perfectly. Good job.

Would you mind posting your original R-Triggered script?

[MoscowModder]

Sure thing (includes R trigger and strafing, NOT BY ME).

Original GBshield

CODE

//import "std.zh"

//Change these values to match your item setup
const int GBS_SMALL=93;
const int GBS_MAGIC=8;
const int GBS_MIRROR=37;
const int GBS_FAKESMALL=144;
const int GBS_FAKEMAGIC=145;
const int GBS_FAKEMIRROR=146;
const int SFX_GBSHIELD=17;

global script slot_2{
    void run(){
    //Initializations
    bool shieldon;
    int lastdir;
    int gbsound;
    bool setdir = false;
        
        while(true){
            //GBShield strafe setup
            //if( (!(Link->Action==LA_ATTACKING))
            //&& (!(Link->Action==LA_CHARGING))
            //&& (!(Link->Action==LA_SPINNING))) {lastdir=Link->Dir;}


            
            int nw = ComboAt(Link->X + 8, Link->Y + 12);

            if(nowalkshield(nw)){          
                Link->Item[GBS_MIRROR]=false;
                Link->Item[GBS_MAGIC]=false;
                Link->Item[GBS_SMALL]=false;
                shieldon=false;
                setdir=false;
            }

            else if(Link->InputR && !shieldon){ //Enable shield when R is pressed
            //else if( UsingItem(GBS_FAKESMALL) || UsingItem(GBS_FAKEMAGIC) || UsingItem(GBS_FAKEMIRROR) ) //Enable shield when using dummy
                shieldon=true;
                if(!setdir)
                {
                    lastdir=Link->Dir;
                    setdir=true;
                }
                gbsound=SFX_GBSHIELD;
                if(Link->Item[GBS_FAKEMIRROR]) Link->Item[GBS_MIRROR]=true;
                else if(Link->Item[GBS_FAKEMAGIC]) Link->Item[GBS_MAGIC]=true;
                else if(Link->Item[GBS_FAKESMALL]) Link->Item[GBS_SMALL]=true;
                else{
                    gbsound=0;
                    shieldon=false;
                    setdir=false;
                }
                if(gbsound>0) Game->PlaySound(SFX_GBSHIELD);
            }
            else if(!Link->InputR && shieldon){ //Remove shield when R is released
                Link->Item[GBS_MIRROR]=false;
                Link->Item[GBS_MAGIC]=false;
                Link->Item[GBS_SMALL]=false;
                shieldon=false;
                setdir=false;
            }

            //check if the hookshot is on screen
            bool nohookshotonscreen = true;
            for(int i=1;i<=Screen->NumLWeapons();i++){
                lweapon testedlw = Screen->LoadLWeapon(i);
                if(testedlw->ID == LW_HOOKSHOT)
                    nohookshotonscreen=false;
            }
            
            bool dirchecks = Link->InputR
                && shieldon
                && (!(Link->Action==LA_ATTACKING))
                && (!(Link->Action==LA_CHARGING))
                && (!(Link->Action==LA_SPINNING))
                && nohookshotonscreen;

            
            //Turn off inputs "L" and "R".
            Link->InputL=false;
            Link->InputR=false;    


            //Strafe while R is held down
            if(dirchecks){
                Link->Dir=lastdir;
            }

            Waitframe();
            }                 // end while
        }                  //end void run

    bool nowalkshield(int underlink){
        underlink = ComboAt(Link->X, Link->Y + 8);
        return (Screen->ComboT[underlink] == 31) || (Screen->ComboT[underlink] == 32) || (Screen->ComboT[underlink] == 33) || (Screen->ComboT[underlink] == 34)
         || (Screen->ComboT[underlink] == 120) || (Screen->ComboT[underlink] == 121) || (Screen->ComboT[underlink] == 122) || (Screen->ComboT[underlink] == 19)
         || (Screen->ComboT[underlink] == 89) || (Screen->ComboT[underlink] == 90) || (Screen->ComboT[underlink] == 91) || (Screen->ComboT[underlink] == 6)
         || (Screen->ComboT[underlink] == 18) || (Screen->ComboT[underlink] == 86) || (Screen->ComboT[underlink] == 87) || (Screen->ComboT[underlink] == 88)
         || (Screen->ComboT[underlink] == 38) || (Screen->ComboT[underlink] == 36) || (Screen->ComboT[underlink] == 39) || (Screen->ComboT[underlink] == 40)
         || (Screen->ComboT[underlink] == 37) || (Screen->ComboT[underlink] == 3);
    }
}

[Jared]

I set it up. But, it's still not showing up in my subscreen. I have no idea why. Can you help me...again? And with a more detailed setup?

[SUCCESSOR]

Well since I have no idea what could be wrong i will just go through it all.

Create a new item: Say #255
Name it after what ever shield you want it to work as.
Set it's class to Custom Class 20
Set as Equipment Item
Set level 1 for Small Shield, 2 For Magic, 3 For mirror
pick the tile you want to use
Set the action script to whatever slot the shield script is on
set arguments

Edit the default subscreen (you can check which one is used by going to Quest > Dmaps > 0 > Appearance)
Right click on an item (the Bait for instance) and click properties.
Change item class to Custom Class 20
Your item should show up there now instead of the Bait.

Set the Item to a screen.

Now play the quest an it should pick up.

I just did exactlyl this on a brand new qst file and it worked(not perfectly as it did on my quest, i don't know why).

EDIT: (Obviously I also Imported the script, compiled it, and set it to Global slot 2, and an item slot)

Edited by SUCCESSOR, 22 May 2012 - 05:00 PM.

[Jared]

I did all of that! But it's still not showing up, and I can't use it.

Did I miss something in the new script that I have to edit or something??

[MoscowModder]

Would you mind sending me your file to see what you did wrong? Or else making a test quest how you set it up?

[Jared]

I have been using a test quest.

I put both the shield and shield dummy, because I didn't know if I needed both.

http://www.mediafire...p1ay849c7yzg1u1

[SUCCESSOR]

I did all of that! But it's still not showing up, and I can't use it.

Did I miss something in the new script that I have to edit or something??

The problem you are describing has nothing to do with the script. The script waits for you to get the item and use it which triggers the item script which in turn triggers the global script. If you cannot acquire the item then the problem is originating before the scripts come into play.

If the problem was that you acquired the dummy shield but when you used it it did nothing. That would be a problem with either the script or how the script was set up.

For instance when i loaded the script into a blank quest to test it out. I set up only the Magic Shield and when I acquired the dummy magic shield in game it set the small shield permanently, so pushing B basically toggled between the small and magic shield. Thats a script problem. Picking up the dummy shield but it not showing up in the subscreens isn't.

I have been using a test quest.

I put both the shield and shield dummy, because I didn't know if I needed both.

http://www.mediafire...p1ay849c7yzg1u1

Looks like you didn't set it up in the subscreen.

Edit Active (NEW, B) subscreen, right click on bait, click properties, change Class to Custom Class 1

Edited by SUCCESSOR, 22 May 2012 - 10:24 PM.

[Jared]

I did set it up! It's in the first subscreen. It has the sprite of the Z1 Mirror Shield.

Edit - Oh WOW! I forgot to set up the right subscreen! It works perfectly! I'm so sorry for all the trouble I've caused!

Is there a way for it to appear in Link's hand, but not be held up until he presses the shield button?

Thank you so much for the script, btw. Works perfectly.

Edited by Jared, 22 May 2012 - 10:26 PM.