96 replies to this topic

[Alucard648]

No it is the same result

Edit: correct answer is that Quake and Bombos works all i did was try with a new save file again then those 2 works but not Ether medallion.

Check allegro.log for error messages. Also which ZC version you use?

EDIT: also try this version of spells: http://pastebin.com/gk7zSdSA

Edited by Alucard648, 15 December 2016 - 03:43 PM.

[judasrising]

Check allegro.log for error messages. Also which ZC version you use?

I have no errors in allegro.log and i use 2.50.2

 

edit: with the newfiles the ether does not work and the other two works

Edited by judasrising, 15 December 2016 - 04:42 PM.

[Alucard648]

The only other way for script not working is a conflict with array usage between scripts in quest file. Also stdWeapons.zh uses lweapon IDs 31-33. Also make sure there is no conflicts within misc array usage, notably Lweapon and FFC misc array. Please, tell me, if some of your scripts uses Misc array for their needs.

[judasrising]

The only other way for script not working is a conflict with array usage between scripts in quest file. Also stdWeapons.zh uses lweapon IDs 31-33. Also make sure there is no conflicts within misc array usage, notably Lweapon and FFC misc array. Please, tell me, if some of your scripts uses Misc array for their needs.

Since i really dont know what i should look for i ask you if i can send all my scripts that i use in the test file and you take a look.

[Timelord]

Ran test on my stdWeaponsDemo. Weapon works fine in ZC 2.5.2. Apparently a conflict with other scripts can occur.

As for LA_CASTING: This does not work for some reason in the current ZC version.

 

Did you mean that setting Link->Action = LA_CASTING broke in 2.50.2?

 

That's the first I've heard of this. Confirm please?

[Alucard648]

Did you mean that setting Link->Action = LA_CASTING broke in 2.50.2?

 

That's the first I've heard of this. Confirm please?

Just run stdWeapons demo quest in 2.5.2, get any LttP medallion spell and cast it.

[Timelord]

Just run stdWeapons demo quest in 2.5.2, get any LttP medallion spell and cast it.

 

I tried it with a quick test script, to verify that it was in fact a ZC issue. Sadly, confirmed; and logged on AGN.

import "std.zh"


global script a{
    void run(){
        int timer = 120;
        while(true){
            if ( Link->PressEx1 ) {
                while ( --timer) { Link->Action = LA_CASTING; Waitdraw(); Waitframe(); }
                timer = 120;
            }
            Waitdraw(); Waitframe();
        }
    }
}

Edited by ZoriaRPG, 17 December 2016 - 11:22 PM.

[Timelord]

Just run stdWeapons demo quest in 2.5.2, get any LttP medallion spell and cast it.

Also, in what version did it work?

 

If you have something to show that, it'd be helpful to debug/fix it. Saffith asked me for something to show that it ever worked, and at present, I'm not sure that I ever had anything.

 

I'd need to check if you can set the Din's Fire sprites in 2.50.2, as I've been using the 2.54 stuff to tinker, but if you can, then to replicate the internal casting animation, using an item class of Din's Fire, clear the sprites (set to a blank sprite), and set the editor values 'Number of Flames' and 'Circle Width' to 0.

 

You can put your launcher script on that, and you may even be able to use the internal sprite selection to your advantage, for the 'rocket up/down' effect.

Edited by ZoriaRPG, 18 December 2016 - 04:40 AM.

[Alucard648]

Also, in what version did it work?

 

If you have something to show that, it'd be helpful to debug/fix it. Saffith asked me for something to show that it ever worked, and at present, I'm not sure that I ever had anything.

 

I'd need to check if you can set the Din's Fire sprites in 2.50.2, as I've been using the 2.54 stuff to tinker, but if you can, then to replicate the internal casting animation, using an item class of Din's Fire, clear the sprites (set to a blank sprite), and set the editor values 'Number of Flames' and 'Circle Width' to 0.

 

You can put your launcher script on that, and you may even be able to use the internal sprite selection to your advantage, for the 'rocket up/down' effect.

LA_CASTING never worked in any version.

 

Din`s Fire class. This will prevent Custom Item classes from being used.

[Timelord]

LA_CASTING never worked in any version.

 

Din`s Fire class. This will prevent Custom Item classes from being used.

 

Fair enough. I'll see if I can make it do something in a future build; as long as this isn't something that broke.

[Shadowblitz16]

@Alucurd648

 

is there a way to offset item when its on a certain frame?

I ask this because I want to make a slash where the sword is 3 pixels closer to link when the slash is on the mid frame.

 

here is an example

 animated

 static

[Alucard648]

@Alucurd648

 

is there a way to offset item when its on a certain frame?

I ask this because I want to make a slash where the sword is 3 pixels closer to link when the slash is on the mid frame.

 

here is an example

 animated

 static

Mid-slash? Unfortunately, you can`t control melee weapon stuff midway trough sequence because Zscript doesn`t allow code injection into function. 

[Shadowblitz16]

can you possibly create a function for it? or functions that allow something like what I'm trying to do?

 

maybe a overload function that takes a array of offsets for each frame for each type of slash

Edited by Shadowblitz16, 01 January 2017 - 07:38 PM.

[Shadowblitz16]

@Alucard648 better yet you could allow collisions on MeleeWeaponDraw() with a bool argument

this way people can animated their weapons the way they want to if they don't like the build in functions

 

please add this feature! I am waiting on a way to create my gameboy sword script and this would do perfectly

[Shadowblitz16]

@Alucard648 your scripts have bugs in them

the sword is not flipped right and it doesn't trigger link's slashing frames

https://gfycat.com/W...morphobutterfly

here is the code

Spoiler

const int HURRICANE_SPIN_NUMSPINS = 20;//Number of spins for Hurricane Spin technique.
const int SPIN_ATTACK_DAMAGE_MODIFIER = 2; //Spin attack damage multiplier.
const int HURRICANE_SPIN_DAMAGE_MODIFIER = 4; //Hurricane Spin damage multiplier.
const int PERIL_SCROLL_HP_THRESHOLD = 16;//Peril Beam technique HP threshold.
const int SWORD_BEAM_SHARD_PARTICLE = 105;//Particle sprite for beam shattering.
const int SWORD_BEAM_SPEED = 300;//Speed of sword beam.
 
//D0-Damage
//D1-Sprite used
//D2-hearts needed to fire sword beams. Negative to have MaxHP precentage requirement.
//D3-Demage from beams. Set to negative for penetrating beams.
//D4, D5 - 2 secret flags to detect with tapping.
//D6 - Sprite for sword beam.
ffc script FFC_Sword{
void run(int dam, int sprite, int beamhearts, int beamdamage, int secrettapdetect1, int secrettapdetect2, int beamsprite){
 
lweapon l = LweaponInit (this, LW_GHOSTED, dam, sprite, 30);
int OrigHitboxData[4]={0,0,5,5};
bool canSlash  = Game->Generic[GEN_CANSLASH];
bool canSpin1  = Link->Item[I_SPINSCROLL1];
bool canSpin2  = Link->Item[I_SPINSCROLL2];
bool canCharge1 = Link->Item[I_CHARGERING1];
bool canCharge2 = Link->Item[I_CHARGERING2];
 
int counter=0;
int chargetype = 0;
int spinattack = 128;
int hurricane  = 256;
 
SetLweaponHitboxOffsets(l, 0, 0, 5, 5);
 
if (!canSlash)
MeleeWeaponStab(this, l, l->Misc[LWEAPON_MISC_ORIGTILE], 2, 12, 79, 141, NPCD_SWORD, 41, 2);
else 
MeleeWeaponSlash90Alt(this, l, l->Misc[LWEAPON_MISC_ORIGTILE], 2, 20, 79, 141, NPCD_SWORD, 41, 2);
 
if (!canSpin1){
LaunchSwordBeam(beamdamage, beamsprite, Link->Dir, beamhearts, SWORD_BEAM_SHARD_PARTICLE, this->InitD[7]);
MeleeWeaponEndStrike(this, l, l->Misc[LWEAPON_MISC_ORIGTILE],2, 2,2);
}
 
MeleeWeaponDraw(this, l, l->Misc[LWEAPON_MISC_ORIGTILE], 1, 8);
 
if (canCharge2) spinattack=32;
else if (canCharge1) spinattack=64;
 
if (canCharge2) hurricane=64;
else if (canCharge1) hurricane=128;
 
LweaponSetFlag(l,LWF_SWING_WHILE_WALKING);
 
while (UsingItem(this->InitD[7])){
 
if (Link->Dir!=l->Dir){ 
MeleeWeaponDraw(this, l, l->Misc[LWEAPON_MISC_ORIGTILE], 1, 8);
AutoRotateLweaponHitbox(l, OrigHitboxData);
}
counter++;
if ((counter>= spinattack)&&(chargetype==0)){
Game->PlaySound(SFX_CHARGE1);
chargetype=1;
}
if ((counter>= hurricane)&&(canSpin2)){
if (chargetype==1){
if (AmmoManager(CR_MAGIC, 8, 118, false)){
Game->PlaySound(SFX_CHARGE2);
chargetype=2;
}
}
}
if ((chargetype>0)&&(counter%15==0)) TapForSecretFlags(this, l, secrettapdetect1, secrettapdetect2);
LweaponWaitframe (this, l, true);
}
LweaponUnSetFlag(l,LWF_SWING_WHILE_WALKING);
int numspins=0;
if (chargetype==2){
numspins = HURRICANE_SPIN_NUMSPINS;
l->Damage*=HURRICANE_SPIN_DAMAGE_MODIFIER;
}
else if (chargetype==1){
numspins =1;
l->Damage*=SPIN_ATTACK_DAMAGE_MODIFIER;
}
if (numspins>1) LweaponSetFlag(l,LWF_SWING_WHILE_WALKING);
for (int i=1; i<=numspins;i++){
Game->PlaySound(SFX_SPINATTACK);
MeleeWeaponSlash360(this, l, l->Misc[LWEAPON_MISC_ORIGTILE], 2, 12, 79, 141, NPCD_SWORD, 41, 1);
}
LweaponUnSetFlag(l,LWF_SWING_WHILE_WALKING);
if ((Link->Item[I_CROSSSCROLL])&&(chargetype>0)){
for (int i=0;i<4;i++){
LaunchSwordBeam(beamdamage, beamsprite,i, beamhearts, SWORD_BEAM_SHARD_PARTICLE, this->InitD[7]);
}
}
else LaunchSwordBeam(beamdamage, beamsprite, Link->Dir, beamhearts, SWORD_BEAM_SHARD_PARTICLE, this->InitD[7]);
MeleeWeaponEndStrike(this, l, l->Misc[LWEAPON_MISC_ORIGTILE], 2, 2,2);
}
}
 
void LaunchSwordBeam(int damage, int sprite, int dir, int hearts, int shardparticle, int itm){
if (damage<=0) return;
bool canshoot=false;
if ((Link->HP<=PERIL_SCROLL_HP_THRESHOLD)&&(Link->Item[I_PERILSCROLL])) canshoot=true;
if ((hearts<0)&&(Link->HP>=((Link->MaxHP)*(Abs(hearts)/100)))) canshoot=true;
if ((hearts>0)&&(Link->HP>=hearts)) canshoot=true;
if (!canshoot) return;
//Game->PlaySound(32);
int args[8] = {damage, sprite, SWORD_BEAM_SPEED/100, shardparticle, dir ,0,0, itm};
int buffer[] = "SwordBeam";
int scr = Game->GetFFCScript(buffer);
ffc beam = LaunchScriptedLweapon(scr, args); 
}
 
void TapForSecretFlags(ffc f, lweapon l, int flag1, int flag2){
if (!IsTappingSolidCombo (l)) return;
MeleeWeaponDraw(f, l, l->Misc[LWEAPON_MISC_ORIGTILE], 1, 12);
if (ComboAnyFlagCollision (flag1, l, false, -1))Game->PlaySound(SFX_TAP2);
else if(ComboAnyFlagCollision (flag2, l, false, -1))Game->PlaySound(SFX_TAP2);
else Game->PlaySound(SFX_TAP1);
MeleeWeaponDraw(f, l, l->Misc[LWEAPON_MISC_ORIGTILE], 1, 8);
}
 
//Returns TRUE if Link tries to tap solid combo with scripted sword.
bool IsTappingSolidCombo (lweapon sword){
if (Screen->isSolid((Link->X + 8), (Link->Y - 1))){
if ((Link->InputUp)&&(sword->Dir == DIR_UP)) return true;
}
if (Screen->isSolid((Link->X + 8), (Link->Y + 17))){
if ((Link->InputDown)&&(sword->Dir == DIR_DOWN)) return true;
}
if (Screen->isSolid((Link->X - 1), (Link->Y + 8))){
if ((Link->InputLeft)&&(sword->Dir == DIR_LEFT)) return true;
}
if (Screen->isSolid((Link->X + 17), (Link->Y + 8))){
if ((Link->InputRight)&&(sword->Dir == DIR_RIGHT)) return true;
}
return false;
}
 
ffc script SwordBeam{
void run (int damage, int sprite, int speed, int particle, int dir){
lweapon l = LweaponInit (this, LW_GHOSTED, Abs(damage), sprite, SFX_BEAM);
SetLweaponHitboxOffsets(l, 0, 0, 5, 5);
int OrigHitboxData[4]={0,0,8,8};
if (dir==DIR_UP) this->Y-=12;
if (dir==DIR_DOWN) this->Y+=12;
if (dir==DIR_LEFT) this->X-=12;
if (dir==DIR_LEFT) this->X+=12;
if (damage<0) LweaponSetFlag(l, LWF_PENETRATING);
LweaponSetFlag(l, LWF_AUTO_DIR_UPDATE);
LweaponSetFlag(l, LWF_AUTO_SPRITE_UPDATE);
LweaponSetFlag(l, LWF_NO_FALL);
SetEnemyDefense(l, NPCD_BEAM);
SetStraightMotion4(this, dir, speed);
while (l->isValid()){
AutoRotateLweaponHitbox (l, OrigHitboxData);
LweaponWaitframe (this,l, false);
}
int angle=45;
int flip[4]={3,2,0,1};
//for (int i=0;i<4;i++){
// lweapon p = CreateParticle (this->X, this->Y, particle, 0, 0, 0, 0, 30, false);
// SetParticleAngularMovement(p, angle,1.5);
// p->Flip=flip[i];
// angle+=90;
//}
}
}

Edited by Shadowblitz16, 07 January 2017 - 08:47 PM.