5 replies to this topic

[Jared]

https://www.purezc.n...76540&p=1060126

 

As seen in this thread, arrows made by using the wand item, pierce enemies instead of hitting and disappearing.

 

2.55 build 85.

Edited by Jared, 23 February 2021 - 09:17 AM.

[Mitchfork]

This is due to behavior where arrows created by any source other than the native bow item pierce enemies by default. 

 

I don't think there's a direct way to set this via scripting.  You have indirect control over this via setting lweapon->Parent to an arrow item with an unchecked "Penetrate Enemies" flag.

 

Zoria mentioned that this is a bug here: https://www.purezc.n...76540&p=1060229

 

I don't disagree, but this behavior has probably been around long enough that somebody may have relied on it. I can update my scripts since I'm still in development but I have a bow item that assumes this behavior.  Maybe "Script-created arrows don't pierce by default" could be a Quest Script Setting or Quest Option?

[Russ]

I can confirm that fixing this bug without a quest rule would break older quests. I have quests that rely upon the piercing behaviour.

[Timelord]

I can confirm that fixing this bug without a quest rule would break older quests. I have quests that rely upon the piercing behaviour.

 

Wait a moment... CreateLWeapon(LW_ARROW) always pierced in 2.50? I do not recall that. I would expect penetration to be off by default.

 

Also, the original report seems to only apply to the Weapon Type field in the 2.55 item editor. I think that CreateLWeaponEx() would be able to circumvent this, and that perhaps in this case the flag 'Allow Magic w/o Book' is being used when you set the wand to create arrow weapons.

This is due to behavior where arrows created by any source other than the native bow item pierce enemies by default. 

 

I don't think there's a direct way to set this via scripting.  You have indirect control over this via setting lweapon->Parent to an arrow item with an unchecked "Penetrate Enemies" flag.

 

Zoria mentioned that this is a bug here: https://www.purezc.n...76540&p=1060229

 

I don't disagree, but this behavior has probably been around long enough that somebody may have relied on it. I can update my scripts since I'm still in development but I have a bow item that assumes this behavior.  Maybe "Script-created arrows don't pierce by default" could be a Quest Script Setting or Quest Option?

 

 

If you give the player the magic book, and in the Item Editor, under Flags for the Wand, deselect  'Allow Magic w/o Book;, do the arrows still pierce?

This is the block of code in question, and why I think this is happening in 2.55, but why I think that it should not be the case for script-generated weapons: Those simply rely on the flags for the highest level arrow in inventory...
 
 

// Penetrating weapons
	if((wpnId==wArrow || wpnId==wBeam) && !cannotpenetrate())
	{
		int item=enemyHitWeapon;
		
		if(wpnId==wArrow)
		{
			if(item<0)
				item=current_item_id(itype_arrow);
				
			if(item>=0 && (itemsbuf[item].flags&ITEM_FLAG1))
				return 0;
		}
		
		else
		{
			if(item<0)
				item=current_item_id(itype_sword);
				
			if(item>=0 && (itemsbuf[item].flags&ITEM_FLAG3))
				return 0;
		}
	}

[P-Tux7]

This is the block of code in question, and why I think this is happening in 2.55, but why I think that it should not be the case for script-generated weapons: Those simply rely on the flags for the highest level arrow in inventory...

This makes no sense, because you might want different kinds of script-generated arrows to pierce or not, and also not have the Arrow item influence that.

[Emily]

This makes no sense, because you might want different kinds of script-generated arrows to pierce or not, and also not have the Arrow item influence that.

Firstly, they are not script-generated. Secondly, they are LW_MAGIC, not LW_ARROW; but they have 'lweapon->Weapon = LW_ARROW;'.