Jump to content

Photo

Minimap after getting map item on overworld


  • Please log in to reply
19 replies to this topic

#16 Emily

Emily

    Scripter / Dev

  • ZC Developers

Posted 26 December 2020 - 05:23 AM

Followup: Bug fixed for next build. Overworlds will update to the "With Map" tiles once picking up a map.

Be sure in the next build to UNCHECK 'Quest>>Options>>Backwards Compatibility>>2>>"Overworld Minimap Ignores Map Item"' to allow this to be fixed.


  • Twilight Knight, Lightwulf and Bagu like this

#17 Bagu

Bagu

    Fandomizer

  • Members
  • Real Name:A.I. Bot Bottomheimer
  • Location:Germany

Posted 26 December 2020 - 05:31 AM

Followup: Bug fixed for next build. Overworlds will update to the "With Map" tiles once picking up a map.

Be sure in the next build to UNCHECK 'Quest>>Options>>Backwards Compatibility>>2>>"Overworld Minimap Ignores Map Item"' to allow this to be fixed.

FANTASTIC NEWS!!!!
Thank you for adding this feature


  • Lightwulf likes this

#18 Lüt

Lüt

    Germanize

  • Members
  • Real Name:Steve
  • Location:Chicago

Posted 26 December 2020 - 07:11 AM

Well that was amazingly fast.

 

Looks like I'll be making custom-drawn overworld minimaps after all.


  • Twilight Knight, Lightwulf and Bagu like this

#19 Emily

Emily

    Scripter / Dev

  • ZC Developers

Posted 26 December 2020 - 01:21 PM

For the record, here was the bug:

case dmOVERW:
case dmBSOVERW:
	if(DMaps[get_currdmap()].minimap_1_tile)
	{
	draw_block(dest,x,y,DMaps[get_currdmap()].minimap_1_tile,DMaps[get_currdmap()].minimap_1_cset,5,3);
	}

Instead of

case dmOVERW:
case dmBSOVERW:
{
	int maptile=(!get_bit(quest_rules, qr_BROKEN_OVERWORLD_MINIMAP) && has_item(itype_map, get_dlevel()))?DMaps[get_currdmap()].minimap_2_tile:DMaps[get_currdmap()].minimap_1_tile;
	int mapcset=(!get_bit(quest_rules, qr_BROKEN_OVERWORLD_MINIMAP) && has_item(itype_map, get_dlevel()))?DMaps[get_currdmap()].minimap_2_cset:DMaps[get_currdmap()].minimap_1_cset;
	if(maptile)
	{
		draw_block(dest,x,y,maptile,mapcset,5,3);
	}

The `get_bit()` check is just for the compat QR. Dungeon/Cave looks like:

case dmDNGN:
case dmCAVE:
{
	int maptile=has_item(itype_map, get_dlevel())?DMaps[get_currdmap()].minimap_2_tile:DMaps[get_currdmap()].minimap_1_tile;
	int mapcset=has_item(itype_map, get_dlevel())?DMaps[get_currdmap()].minimap_2_cset:DMaps[get_currdmap()].minimap_1_cset;
	if(maptile)
	{
		draw_block(dest,x,y,maptile,mapcset,5,3);
	}

So yeah, overworlds were just using the 'Without Map' tile and not even checking if you have the map.


  • Twilight Knight, Lightwulf and Bagu like this

#20 Twilight Knight

Twilight Knight

    Tell all with glee, Argon's on PureZC

  • Members
  • Real Name:Sven
  • Location:Rotterdam, NL

Posted 27 December 2020 - 11:47 AM

Oh that's awesome, thanks for fixing this!


  • Lightwulf and Bagu like this


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users