44 replies to this topic

[MoscowModder]

It has been fixed. Updated script above ^^

[Jenny]

Okay, that sorta fixed the solid combo problem, but now it keeps getting stuck in random places, being unable to move...?

[tox_von]

wouldnt some kind of random movement function like this be easier?

CODE

import "std.zh"

ffc script dogs
{
    void run()
    {
       int frames = 0;
       int a = 0;
      
       while(true)
       {
        a = Rand(2);
        frames ++;
        if (frames > 0 && frames < 20 && a == 0) this->X ++;
        if (frames > 0 && frames < 20 && a == 1) this->X --;
        if (frames > 20 && frames < 40 && a == 0) this->X --;
        if (frames > 20 && frames < 40 && a == 1) this->X ++;
        if (frames == 41) frames = 0;
        if (this->X > 256) this->X= 1;
        Waitframe();
       }
    }
}

[Shane]

wouldnt some kind of random movement function like this be easier?

CODE

import "std.zh"

ffc script dogs
{
    void run()
    {
       int frames = 0;
       int a = 0;
      
       while(true)
       {
        a = Rand(2);
        frames ++;
        if (frames > 0 && frames < 20 && a == 0) this->X ++;
        if (frames > 0 && frames < 20 && a == 1) this->X --;
        if (frames > 20 && frames < 40 && a == 0) this->X --;
        if (frames > 20 && frames < 40 && a == 1) this->X ++;
        if (frames == 41) frames = 0;
        if (this->X > 256) this->X= 1;
        Waitframe();
       }
    }
}

Have you tested and confirmed that this is issue-free? Also mind if you give us the information on what arguments are what?

[tox_von]

all it does is skid around from left to right randomly. What i was suggesting was that movement like this would be easier than writing massive complicated scripts. What else would it need to do?

[Shane]

That wasn't my question, I asked is it issue-free and what are the arguments given in this script, as I assume there will be arguments.

Left to right? Why not up and down too?

[tox_von]

i dont think there can be anything wrong with my script other than its underdeveloped and can do more if anyone wants it to using the frame counter idea. All it does is put a ffc on the screen theres no collision stuff.

[MoscowModder]

There are no arguments, there is no solidity checking, there is no up/down movement. Easier =/= better.

[Jenny]

Okay, that sorta fixed the solid combo problem, but now it keeps getting stuck in random places, being unable to move...?

I can't use these when they keep on getting stuck

[MoscowModder]

What makes them get stuck? Can you tell?

Did you accidentally change those constants (starting with ANIMAL_ATTRIB_) again?

[Jenny]

No, I didn't change anything.

I think it has something to do with the hopping...

[Mero]

You're using ghost->Dir not Ghost_Dir. That's why it's getting stuck I think.

[MoscowModder]

That doesn't happen in my test. Try replacing your version with this (just in case):

Script

CODE

//import "std.zh"
//import "string.zh"
//import "ghost.zh"

//Attributes
//Type: Walking enemy
//Step speed: How fast to move
//3 = Death Attr 1: How high to jump
//4 = Death Attr 2: How long to stand still
//5 = Death Attr 3: How long to move
//6 = Extra shots: Collision detection (0: intangible; 1: deals damage and can be killed)
//11 = MUST BE equal to GH_INVISIBLE_COMBO in ghost.zh
//12 = Script slot number (check as you're assigning this to an FFC slot)

//DO NOT ALTER THESE CONSTANTS.
const int ANIMAL_ATTRIB_JUMPHEIGHT = 2;
const int ANIMAL_ATTRIB_STANDTIME = 3;
const int ANIMAL_ATTRIB_MOVETIME = 4;
const int ANIMAL_ATTRIB_COLLDETECT = 5;

ffc script animalNPC{
    void run ( int enemyID ){
        //Initialize the autoghost 'enemy'
        npc ghost = Ghost_InitAutoGhost(this, enemyID, GHF_SET_DIRECTION | GHF_4WAY);
        int moveCounter = 0 + Rand(ghost->Attributes[ANIMAL_ATTRIB_STANDTIME]);
        bool moving = false;
        ghost->CollDetection = ghost->Attributes[ANIMAL_ATTRIB_COLLDETECT];
        int ghostStep = ghost->Step; //Save step speed
        while ( true ){
        
            //If it is moving and on the ground
            if ( moving && ghost->Z == 0 ){
                Ghost_Jump = ghost->Attributes[ANIMAL_ATTRIB_JUMPHEIGHT]; //Jump
            }
            
            //Move the ghost
            Ghost_Move( ghost->Dir, ghost->Step/100, 0 );
            
            //Increment move counter
            moveCounter++;
            if ( moving && moveCounter > ghost->Attributes[ANIMAL_ATTRIB_MOVETIME] ){
                moving = false;
                moveCounter = 0 + Rand(ghost->Attributes[ANIMAL_ATTRIB_MOVETIME])/10;
                ghost->Step = 0;
            }
            else if ( !moving && moveCounter > ghost->Attributes[ANIMAL_ATTRIB_STANDTIME] ){
                moving = true;
                moveCounter = 0 + Rand(ghost->Attributes[ANIMAL_ATTRIB_STANDTIME])/10;
                ghost->Dir = Rand(8);
                ghost->Step = ghostStep;
            }
            
            //Special waitframe for autoGhost scripts
            Ghost_Waitframe(this, ghost, true, true);
        }
    }
}

And if that doesn't work, list all of your animal's attributes.

Edited by MoscowModder, 22 April 2012 - 06:18 PM.

[Jenny]

1
60
90

[MoscowModder]

Maybe I should just take another look at the quest file.