11 replies to this topic

[Jared]

Can anyone make this an ITEM for me? Like, you put it to A or B, and you can buy it normally, etc? And you use it by pressing the button, with NO strafing?
Also, can you make it so if you have it on A or B, it shows up (On his arm), but not when you don't have it on A or B?
Thank you SO much!

On a side note, would it be possible to make Link use a "push" tile when he pushes on a block flag? That's be awesome too!

[Russ]

Alright, I tried my hand at this. I couldn't get the part where it Link's sprites change if he has the shield equipped to work, because I don't know how to properly check what item he currently has equipped ( ), but I tried my best at the rest of it. It compiles alright, but I didn't have time to test it, so let me know if it screws up (it probably will...) Instructions after the code

CODE

bool shielding = false;
int shieldingup = 1;
int shieldingdown = 2;
int shieldingleft = 3;
int shieldingright = 4;
int shield = 12;


item script GBshield {
    void run() {
        shielding = true;
    }
}


global script slot_2 {
    void run() {
        while (true) {
            if (shielding == false) {
                Link->Invisible = false;
            }
            if (shielding == true) {
                Link->InputUp = false;
                Link->InputDown = false;
                Link->InputLeft = false;
                Link->InputRight = false;
                Link->Item[shield] = true;
                Link->Invisible = true;
                if (Link->Dir == 0) {
                    Screen->DrawTile(0, Link->X, Link->Y, shieldingup, 0, 0, 6, -1, -1, 0, 0, 0, 0, true, 128);
                }

                if (Link->Dir == 1) {
                    Screen->DrawTile(0, Link->X, Link->Y, shieldingdown, 0, 0, 6, -1, -1, 0, 0, 0, 0, true, 128);
                }

                if (Link->Dir == 2) {
                    Screen->DrawTile(0, Link->X, Link->Y, shieldingleft, 0, 0, 6, -1, -1, 0, 0, 0, 0, true, 128);
                }

                if (Link->Dir == 3) {
                    Screen->DrawTile(0, Link->X, Link->Y, shieldingright, 0, 0, 6, -1, -1, 0, 0, 0, 0, true, 128);
                }
                shielding = false;
            }
                Waitframe();
        }
    }
}

You're going to need four tiles, tiles showing Link holding up his shield while facing up, down, left, and right. Put the numbers for those tiles into the four variables at the top of the script (the ones like "int shieldingup"). Then, go to the item edtior. Find whatever shield you want Link to actually use (for example, if you want this to be the level 2 shield, grab that item's id number). Put that into the variable "int shield" at the top of the script.

Now, make a dummy shield item, and attach the item script "GBshield" to it. Then load the global script into slot 2, combining it with other global scripts if you need to.

Like I said, I don't have time to test this. I tested to make sure it compiles, but I didn't test if it actually works, so let me know what happens so I can try to fix it (if it's broken).

[MoscowModder]

I think it would be much easier to handle Link's graphics with Link Tile Modifiers instead of drawtiles. You may want to use the code from the old GBshield script. It is similar to what you want except that it activates the shield when you press R and it has strafing.

Script

CODE

//import "std.zh"

//Change these values to match your item setup
const int GBS_SMALL=93;
const int GBS_MAGIC=8;
const int GBS_MIRROR=37;
const int GBS_FAKESMALL=144;
const int GBS_FAKEMAGIC=145;
const int GBS_FAKEMIRROR=146;
const int SFX_GBSHIELD=17;

global script slot_2{
    void run(){
    //Initializations
    bool shieldon;
    int lastdir;
    int gbsound;
    bool setdir = false;
        
        while(true){
            //GBShield strafe setup
            //if( (!(Link->Action==LA_ATTACKING))
            //&& (!(Link->Action==LA_CHARGING))
            //&& (!(Link->Action==LA_SPINNING))) {lastdir=Link->Dir;}


            
            int nw = ComboAt(Link->X + 8, Link->Y + 12);

            if(nowalkshield(nw)){          
                Link->Item[GBS_MIRROR]=false;
                Link->Item[GBS_MAGIC]=false;
                Link->Item[GBS_SMALL]=false;
                shieldon=false;
                setdir=false;
            }

            else if(Link->InputR && !shieldon){ //Enable shield when R is pressed
                shieldon=true;
                if(!setdir)
                {
                    lastdir=Link->Dir;
                    setdir=true;
                }
                gbsound=SFX_GBSHIELD;
                if(Link->Item[GBS_FAKEMIRROR]) Link->Item[GBS_MIRROR]=true;
                else if(Link->Item[GBS_FAKEMAGIC]) Link->Item[GBS_MAGIC]=true;
                else if(Link->Item[GBS_FAKESMALL]) Link->Item[GBS_SMALL]=true;
                else{
                    gbsound=0;
                    shieldon=false;
                    setdir=false;
                }
                if(gbsound>0) Game->PlaySound(SFX_GBSHIELD);
            }
            else if(!Link->InputR && shieldon){ //Remove shield when R is released
                Link->Item[GBS_MIRROR]=false;
                Link->Item[GBS_MAGIC]=false;
                Link->Item[GBS_SMALL]=false;
                shieldon=false;
                setdir=false;
            }

            //check if the hookshot is on screen
            bool nohookshotonscreen = true;

            for(int i=1;i<=Screen->NumLWeapons();i++){
                lweapon testedlw = Screen->LoadLWeapon(i);
                if(testedlw->ID == LW_HOOKSHOT){nohookshotonscreen=false;}
            }


            
            bool dirchecks = Link->InputR
                && shieldon
                && (!(Link->Action==LA_ATTACKING))
                && (!(Link->Action==LA_CHARGING))
                && (!(Link->Action==LA_SPINNING))
                && nohookshotonscreen;

            //Turn off inputs "L" and "R".
            Link->InputL=false;
            Link->InputR=false;    

            Waitdraw();

            //Strafe while R is held down
            if(dirchecks) {Link->Dir=lastdir;}

            Waitframe();
            }                 // end while
        }                  //end void run

    bool nowalkshield(int underlink){
        underlink = ComboAt(Link->X, Link->Y + 8);
        return (Screen->ComboT[underlink] == 31) || (Screen->ComboT[underlink] == 32) || (Screen->ComboT[underlink] == 33) || (Screen->ComboT[underlink] == 34)
         || (Screen->ComboT[underlink] == 120) || (Screen->ComboT[underlink] == 121) || (Screen->ComboT[underlink] == 122) || (Screen->ComboT[underlink] == 19)
         || (Screen->ComboT[underlink] == 89) || (Screen->ComboT[underlink] == 90) || (Screen->ComboT[underlink] == 91) || (Screen->ComboT[underlink] == 6)
         || (Screen->ComboT[underlink] == 18) || (Screen->ComboT[underlink] == 86) || (Screen->ComboT[underlink] == 87) || (Screen->ComboT[underlink] == 88)
         || (Screen->ComboT[underlink] == 38) || (Screen->ComboT[underlink] == 36) || (Screen->ComboT[underlink] == 39) || (Screen->ComboT[underlink] == 40)
         || (Screen->ComboT[underlink] == 37) || (Screen->ComboT[underlink] == 3);
    }

}

When I have more free time I could try to modify this for you.

[Jared]

Well, I could just make Link hold the shield idly until he puts it on a button item. So no tile editors are needed. ^^
I'll try it. Thank you Russ!

MM, I know, you used that script in PoS. And to be honest, I HATED it. I hated how you had to hold the button that was so far (If you didn't want to move the default button). Pressing 3 buttons at once happened once I think...wasn't pretty. And the strafing I don't like.

Russ, do I make separate items for each shield direction?

[MoscowModder]

No, just one item. Set a different tile for each direction instead.

[Jared]

So he'll float around with one tile, instead of walking?? O_o

[MoscowModder]

That's why I suggested a modification of the old script, which relies on LTMs.

[Russ]

No, he won't walk when he's shielding. I thought you said you didn't want him to be able to. If you do, I'll have to modify the script to use LTMs instead.

[Jared]

I just thought it would be easier for you. But, I need him to walk.

I tired the script ,and set up the tiles (Just for now), and I couldn't move anything when I started the game. I couldn't even pause.

[MoscowModder]

He forgot to put a Waitframe(); right before the end of the while(true) loop. Very common mistake.

[Russ]

Yeah I'm just gonna shoot myself now. You have no idea how many times I make that mistake... I added the waitframe, but since Link can't move with the script, I guess I'll need to rework it anyways.

[Jared]

Okay, no problem. Thanks so much, Russ(el?).