590 replies to this topic

[Saffith]

I caught this in Valgrind:

CODE

==3096== 2 errors in context 1 of 162:
==3096== Invalid write of size 1
==3096==    at 0x8173F3E: go_tiles() (zq_tiles.cpp:288)
==3096==    by 0x818E1B4: select_tile(int&, int&, int, int&, bool, int) (zq_tiles.cpp:6984)
==3096==    by 0x806CA0A: domouse() (zquest.cpp:7101)
==3096==    by 0x8097C44: d_nbmenu_proc(int, DIALOG*, int) (zquest.cpp:22161)
==3096==    by 0x831F6F1: object_message (gui.c:353)
==3096==    by 0x849BD97: ? (in /home/user/Games/Zelda Classic/Latest build/zquest-l)
==3096==  Address 0x116a200f is 7 bytes after a block of size 0 alloc'd
==3096==    at 0x64AB018: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==3096==    by 0x8173DFB: go_tiles() (zq_tiles.cpp:267)
==3096==    by 0x818E1B4: select_tile(int&, int&, int, int&, bool, int) (zq_tiles.cpp:6984)
==3096==    by 0x806CA0A: domouse() (zquest.cpp:7101)
==3096==    by 0x8097C44: d_nbmenu_proc(int, DIALOG*, int) (zquest.cpp:22161)
==3096==    by 0x831F6F1: object_message (gui.c:353)
==3096==    by 0x849BD97: ? (in /home/user/Games/Zelda Classic/Latest build/zquest-l)

I think I just opened ZQuest and went straight to the tile pages via right-clicking in the combo list.
The 0-byte malloc suggests an invalid tile color depth. It's not saved that way in the quest file, and it's not loading incorrectly. I haven't seen that happen again, and I haven't caught any other invalid writes. I've got no idea what might have happened.

[kurt91]

Unrelated issue, not sure if it's a bug or a feature.

I built my Main palette, with everything relying heavily on 8-bit mode. Now, I'm trying to build a dungeon, using the Level 1 palette. I already know that C-Sets 0 and 1 of my Overworld palette will also work in my dungeon palette. Unfortunately, colors 6 and 7 of C-Set 0 are disappearing on me.

They appear in the overworld palette, but disappear into black in my dungeon palette. Is this a bug, or a palette restriction I possibly overlooked? Either way, is it safe to re-insert the correct colors in my dungeon palette in the same location? I'm also using those spots for my subscreen, and I'm afraid that by leaving it alone, I'm going to screw up my item graphics.

That's a new one. Does this happen in other tilesets? If it's just your quest that's doing that, could I take a look at it?

I've never uploaded anything onto MediaFire before, but it seemed like the easiest site to use. Let me know if I screwed up and the link doesn't work.

My Quest

Go to the dungeon map and the tile that shows the problem is the floor torch. The flames appear black in the dungeon palette, but yellow in the overworld palette.

[Saffith]

You've got palette cycling set up there; if you clear it out (set all the numbers to 0), it should work right.

[kurt91]

Two things...

1: Where do I fix the palette cycling problem? I checked under "Edit Combo", but everything is already set to zero there.

2: Is there a way to transfer a save file from one version of ZC to another? I'm having issues with a quest, and need to use a different ZC version to continue. Thing is, I'm far enough in the game that I really don't want to start over.

---
EDIT: Nevermind on the palette cycling problem. I accidentially found what I needed to change, and fixed the issue. Still need help with the second question, though.

Edited by kurt91, 14 March 2012 - 09:28 PM.

[SpacemanDan]

Palette cycling is edited in the level palette editor. :3 (There's a button that says something like 'Cycling' or another. I don't remember as I haven't used palette cycling...ever, actually. D: )

[Saffith]

2: Is there a way to transfer a save file from one version of ZC to another? I'm having issues with a quest, and need to use a different ZC version to continue. Thing is, I'm far enough in the game that I really don't want to start over.

Not back to an older version. What problem are you having? It's probably something we ought to fix.

[kurt91]

I wanted to transfer a save file of DarkFlameWolf's "WolfStyle DX" quest from RC2 to RC3. In level 6, there's a doorway you have to swim through leading north, and for some reason it won't let me through in RC2. I originally just asked her for the password in a PM, so I could just edit the doorway itself, but she doesn't have it anymore. She did recommend trying to play it in RC3 because it's supposed to have better backwards compatibility. (I know I'm supposed to have the Lost Isle build, but I don't. I was actually kind of curious what kinds of problems playing in a newer build would have)

If RC3 can't play the game properly, would that be the type of errors to put up as well? It would seem like a good idea to try to nail backwards compatibility so people only really have to download one definitive version of ZC. (Besides, I can't run 2.10 on my laptop)

[Saffith]

If it doesn't work right, that's a problem, but it ought to. I don't know if we can realistically guarantee b182 quests will behave exactly the same as they originally did, but that would be ideal. Any noticeable differences are worth reporting.

You should be able to transfer saves from RC2 to RC3. Just copy the quest file, zc.sav, and zc.icn to the RC3 directory. You can't merge it with any existing save files, however.
It should also work if replace RC2 itself with RC3 in place.

[Saffith]

So, we've got a possible cause for the crashes. Now I want to confirm it and try to narrow it down a little. Here's a modified zquest-w.exe: http://www.mediafire...7lh52xh9xhmf1fu
It'll validate the format of every tile whenever you enter the tile or combo pages. If it finds any invalid tiles, it'll show a warning message with the tile number and format. It will also write the same message to allegro.log. Let me know if there is such an error and if there's anything remarkable about the tiles that have problems.

[The Satellite]

I'll reiterate my earlier post in the thread, since it seems to be something that people commonly overlook:

It's something I missed at first, anyway. Doesn't help that zq_win_proc_fix is an entry that's in the ag.cfg by default, but zc isn't.

That wasn't it, I had already noticed that first time I tried. Still didn't fix it.

Well, this is quite frustrating. I really thought we were done with all this...
Since I've got almost nothing to go on, I put together another debug build. It would be much appreciated if any of you seeing crashes (excluding those fixed by setting zc/zq_win_proc_fix=0) would try it out. I can't guarantee it'll help, or even work, but I don't have any better ideas right now.

http://www.mediafire...k1u4cammellzkqr

Don't run zelda-w.exe and zquest-w.exe; use zc.bat and zquest.bat instead. The included launcher's fine, too (but not the regular release version). Assuming it works, let me see gdb.log when it crashes. If all goes well, that should identify exactly where it's crashing.

I had even less luck with this one. The original still worked in Aero, the debug ZC switched the theme to basic. And it crashed on the quest select screen without trying to open the menu (this was in windowed mode, launched via the included ZC Launcher and then with zc.bat). As with the original, it works fine in full screen mode, but I like to multitask and my computer takes forever to shift between themes, or else I'd just use the Windows key to switch out of full screen mode.

[Saffith]

Did it create gdb.log?
It should work with Aero if you set disable_direct_updating=1 in the graphics section of ag.cfg. I had forgotten, but it's an older version of the launcher that doesn't do that automatically.

[The Satellite]

It did, I just didn't paste it because I figured it working completely differently from the other version was irrelevant, but, these were the contents: http://pastebin.com/HgGkjrpP

[Saffith]

Hm. Technically, it's not crashing, it's exiting. What's the end of allegro.log look like?

[The Satellite]

I'm actually not sure which part you're looking for (not exactly savvy with this kind of thing), but here's the contents of the log:

Spoiler

Zelda Classic v2.50 Beta (Build 21)
Allocating quest path buffers (4.00k/4.00k)...OK
Allocating map buffer (1008.84k/1012.84k)... OK
Allocating combo buffer (5.98k/1018.82k)... OK
Allocating string buffer (680.00k/1.66M)... OK
Allocating door combo buffer (159.50k/1.81M)... OK
Allocating dmap buffer (234.00k/2.04M)... OK
Allocating combo buffer (1.62M/3.66M)... OK
Allocating color data buffer (314.11k/3.97M)... OK
Allocating tile buffer (8.50M/12.47M)... OK
Allocating trash buffer (97.66k/12.56M)... OK
Allocating item buffer (31.00k/12.59M)... OK
Allocating weapon buffer (2.50k/12.59M)... OK
Allocating guy buffer (35.00k/12.63M)... OK
Allocating combo class buffer (33.30k/12.66M)... OK
Initializing Allegro... al-main INFO: Allegro initialised (instance 1)
OK
Checking Files... OK
Allocating bitmap buffers... OK
Loading data files:
Zelda.Dat...OK
Fonts.Dat...OK
SFX.Dat...OK
Initializing sound driver... OK
Used switch: -fullscreen
al-gfx INFO: Called set_gfx_mode(1, 640, 480, 0, 0).
al-gfx INFO: First call, remembering console state.
al-gfx INFO: Autodetecting graphic driver.
al-gfx INFO: The driver will wait for vsync.
al-gfx INFO: set_gfx_card success for 640x480x8.
set gfx mode succsessful at -1 8bpp 640 x 480
Triplebuffer available
Loading saved games... Save file not found. Creating new save file.OK
Loading Quest...

Decrypting...okay.
Opening...okay.
Loading Quest...

Decrypting...okay.
Opening...okay.
Loading Quest...

Decrypting...okay.
Opening...okay.
Loading Quest...

Decrypting...okay.
Opening...okay.
Loading Quest...

Decrypting...okay.
Opening...okay.
Loading Quest...

Decrypting...okay.
Opening...okay.
al-gfx INFO: Called set_gfx_mode(-1, 80, 25, 0, 0).
al-gfx INFO: Closing graphics driver (00776400) DirectDraw accel.
al-gfx INFO: Closing, restoring original console state.
al-gfx INFO: Graphic mode closed.
Removing timers.
Freeing Data:
Bitmaps...
Subscreens...
SFX...
Misc...
Script buffers...
Screen Data...
Deleting quest buffers...
Cleaning maps.
Cleaning tile buffers.
Cleaning misc.
Armageddon Games web site: http://www.armageddongames.com
Zelda Classic web site: http://www.zeldaclassic.com
Zelda Classic wiki: http://www.shardstorm.com/ZCwiki/

[Freedom]

Saffith,
The above zquest.exe fixed something.
I ran it 5 times with no crash, it would have absolutely crashed with the other in 5 tries.
I got no warnings.