24 replies to this topic

[Shadowblitz16]

Lejes

can you comment the code you gave me so I can understand and learn from it?

[Lejes]

I fixed a bug with slowed movement, and commented most blocks of it. If you're still confused on how something works, just ask. I still don't consider this done, really. There are some issues with diagonal movement that I need to think about how to fix.

Link Speed, Commented

int LinkSpeedVars[5]; // Array of global variables. Following constants are the indices to this array.
const int LS_STEP = 0; // Link's walking speed, in pixels per frame.
const int LS_X = 1; // Holds X values, because Link->X can only be an integer.
const int LS_Y = 2; // Holds Y values, because Link->Y can only be an integer.
const int LS_CUR_SCREEN = 3; // Tracks current screen.
const int LS_CUR_DMAP = 4; // Tracks current DMap.

// Sets all variables to proper values at beginning of global script. LinkSpeedVars[LS_STEP] is set to 2.5 only for testing purposes.
// It can be set to something else using FFC or item scripts during real usage.
void LinkSpeedInit()
{
	LinkSpeedVars[LS_STEP] = 2.5;
	
	LinkSpeedVars[LS_X] = 0;
	LinkSpeedVars[LS_Y] = 0;
	LinkSpeedVars[LS_CUR_SCREEN] = -1;
	LinkSpeedVars[LS_CUR_DMAP] = -1;
}

void LinkSpeed()
{
	float default_step;
	
	// If player changes screen, zero out the X and Y tracking variables.
	if (Game->GetCurDMap() != LinkSpeedVars[LS_CUR_DMAP] || Game->GetCurScreen() != LinkSpeedVars[LS_CUR_SCREEN])
	{
		LinkSpeedVars[LS_X] = 0;
		LinkSpeedVars[LS_Y] = 0;
		LinkSpeedVars[LS_CUR_SCREEN] = Game->GetCurScreen();
		LinkSpeedVars[LS_CUR_DMAP] = Game->GetCurDMap();
	}
	
	// Tries to limit speed when walking diagonally.
	if ((Link->InputUp && Link->InputLeft) || (Link->InputUp && Link->InputRight) || (Link->InputRight && Link->InputDown) || (Link->InputDown && Link->InputLeft))
	{
		default_step = 1.0607; // square root of 1.125
		//default_step = 1.5;
	}
	// Default speed when walking left/right/up/down
	else
	{
		default_step = 1.5;
	}
	// This is zeroed out when LinkSpeedVars[LS_STEP] is less than default walk speed, because it uses an entirely different method.
	if (LinkSpeedVars[LS_STEP] < 1.5)
	{
		default_step = 0;
	}
	
	// Link->Action check is commented out because it doesn't work right with slowing down. Not sure if salvageable.
	//if (Link->Action == LA_WALKING || Link->Action == LA_SWIMMING || Link->Action == LA_DIVING)
	//{
		// X and Y tracking variables are set here. Normal walk speed still happens when you hold a direction, so it has to be subtracted from LinkSpeedVars[LS_STEP].
		// CanWalk() from std.zh is used to make sure Link doesn't go into walls.
		if (Link->InputUp && CanWalk(Link->X, Link->Y, DIR_UP, LinkSpeedVars[LS_STEP], false))
		{
			LinkSpeedVars[LS_Y] -= LinkSpeedVars[LS_STEP] - default_step;
		}
		if (Link->InputDown && CanWalk(Link->X, Link->Y, DIR_DOWN, LinkSpeedVars[LS_STEP], false))
		{
			LinkSpeedVars[LS_Y] += LinkSpeedVars[LS_STEP] - default_step;
		}
		if (Link->InputLeft && CanWalk(Link->X, Link->Y, DIR_LEFT, LinkSpeedVars[LS_STEP], false))
		{
			LinkSpeedVars[LS_X] -= LinkSpeedVars[LS_STEP] - default_step;
		}
		if (Link->InputRight && CanWalk(Link->X, Link->Y, DIR_RIGHT, LinkSpeedVars[LS_STEP], false))
		{
			LinkSpeedVars[LS_X] += LinkSpeedVars[LS_STEP] - default_step;
		}
	//}
	
	// Position shifting for speed increase happens here.
	if (LinkSpeedVars[LS_STEP] > 1.5)
	{
		// If accumulated pixel increase from speedup is 1 pixel or greater, it is added to Link's position.
		// Then the fractional portion is stored again, e.g. LinkSpeedVars[LS_X] == 1.35 would add 1 pixel to Link->X, then be set to 0.35.
		if (Abs(LinkSpeedVars[LS_X]) >= 1)
		{
			Link->X += (LinkSpeedVars[LS_X] << 0);
			LinkSpeedVars[LS_X] -= (LinkSpeedVars[LS_X] << 0);
		}
		if (Abs(LinkSpeedVars[LS_Y]) >= 1)
		{
			Link->Y += (LinkSpeedVars[LS_Y] << 0);
			LinkSpeedVars[LS_Y] -= (LinkSpeedVars[LS_Y] << 0);
		}
	}
	// Input damping for slowing down happens here.
	// Since Link moves 1.5 pixels for every frame a direction is held down, input is set to false until LinkSpeedVars[LS_Y] or LinkSpeedVars[LS_Y]
	// is at least 1.5. Then it's allowed for one frame, then Sign() is used to bring the tracking variable 1.5 pixels closer to 0.
	else if (LinkSpeedVars[LS_STEP] < 1.5)
	{
		if (Abs(LinkSpeedVars[LS_X]) < 1.5)
		{
			Link->InputLeft = false;
			Link->InputRight = false;
		}
		else
		{
			LinkSpeedVars[LS_X] -= Sign(LinkSpeedVars[LS_X]) * 1.5;
		}
		if (Abs(LinkSpeedVars[LS_Y]) < 1.5)
		{
			Link->InputUp = false;
			Link->InputDown = false;
		}
		else
		{
			LinkSpeedVars[LS_Y] -= Sign(LinkSpeedVars[LS_Y]) * 1.5;
		}
	}
	// If LinkSpeedVars[LS_STEP] is exactly 1.5, do nothing, because that's Link's normal walk speed.
	else
	{
		LinkSpeedVars[LS_X] = 0;
		LinkSpeedVars[LS_Y] = 0;
	}
	
	// Adjusts LinkSpeedVars[LS_STEP] between 0 and 3 by pressing Ex1. Used only for testing, remove later.
	if (Link->PressEx1)
	{
		LinkSpeedVars[LS_STEP] += 0.2;
		if (LinkSpeedVars[LS_STEP] > 3)
		{
			LinkSpeedVars[LS_STEP] -= 3;
		}
	}
	// Displays LinkSpeedVars[LS_STEP] and default_step on the top left of the screen.
	Screen->DrawInteger(6, 0, 0, FONT_Z1, 0x01, 0x07, 0, 0, LinkSpeedVars[LS_STEP], 4, OP_OPAQUE);
	Screen->DrawInteger(6, 0, 8, FONT_Z1, 0x01, 0x07, 0, 0, default_step, 4, OP_OPAQUE);
}

[Shadowblitz16]

ok thankyou

 

Edit: Lejes

I Have been comparing it to the game boy speed of link

and it seems even at 0.1 hes a little too fast is there a way to put it on a timer so it can go to really slow speeds?

Edited by Shadowblitz16, 23 October 2016 - 02:31 PM.

[Lejes]

You could theoretically put it all the way down to 0.0005. I'm not sure Game Boy Link is that much slower, though.

[Shadowblitz16]

@Lejes sorry my bad

I'm saying it has a bug in it where you can't slow down link past 1.0

Edited by Shadowblitz16, 23 October 2016 - 07:15 PM.

[Lejes]

I'm not seeing it. Although I am seeing more issues with diagonal movement.

[Shadowblitz16]

have you tested it?

if you make it use a value like 0.005 it will be the same as 0.05 or 0.5

[Lejes]

I made it. So yes, I've tested it. I tested again just now, and a step speed of 0.0005 takes about 50 full seconds to see any movement, as expected.

[Shadowblitz16]

hmm weird I had to remove the waitframe() command at the end of my global active script

 

but now I see what bugs you were talking about

 

I'm going to list some bugs here I found

-Link twitches when he is moving diagonally when slower then 1.5

-Link has hard time opening chests when slower then 1.5

-Link can't stab the wall when slower then 1.5

-Link has hard time scrolling when slower then 1.5

-Link can move in any state when faster then 1.5

Edited by Shadowblitz16, 23 October 2016 - 09:19 PM.

[Shadowblitz16]

@Lejes

 

ok so I decided to go with a much simpler script, one that just delays Link's directional input.

however I can't seem to get ZC collisions to work with it, for example push blocks don't move when Link is next to them

I suspect it has something to do with internal collisions actually checking a step of 1.5 instead of X and Y

 

is there a way to fix something like this?

 

here is my code

int delay = 0;
 
void Link_Update()
{
if ( delay <= 0 ) { delay = 1; }
else 
{
delay -= 1;
Link->InputUp = false; Link->PressUp = false;
Link->InputDown = false; Link->PressDown = false;
Link->InputLeft = false; Link->PressLeft = false;
Link->InputRight = false; Link->PressRight = false;
}

it is much less simpler then the one I was working on before and the one you linked me.

I would use the one you linked but it has many bugs and I don't have the ability to fix them

 

Edit: ok so I can't get the exact speed with this script so nevermind

can you fix the one you gave me and upload it to the database?

I'm sure someone else could use it too.

Edited by Shadowblitz16, 01 November 2016 - 10:00 AM.