5 replies to this topic

[Shadowblitz16]

for some reason comboAt is returning a low number when I am on the bottom of the screen

and when it does this it only decrements and interments when I move down or up.

here is my script

 

Spoiler

const int LINK_PUSH_TILE = 34772;
const int LINK_PUSH_FRAMES = 2;
const int LINK_PUSH_SPEED = 12;
 
int frame = 0;
int delay = 0;
 
void GB_Link_Update()
{
    GB_Link_Push();
}
 
void GB_Link_Push()
{
    int ComboPos;
    int ComboPush = 0;
    int OffsetX = 0;
    int OffsetY = 0;
    int X = 0;
    int Y = 0;
 
if (Link->Dir == 2) { OffsetX == -1; }
else if (Link->Dir == 3) { OffsetX ==  1; }
 
if (Link->Dir == 0) { OffsetY == -1; }
else if (Link->Dir == 1) { OffsetY ==  1; }
    
    X = (Link->X + 7) + (16 * OffsetX);
    Y = (Link->Y + 7) + (16 * OffsetY);
    
    ComboPos  = (ComboAt(Link->X + 7, Link->Y + 7));
    Screen->DrawInteger(6, 0, 0, 0, 20, -1 , 16, 16, ComboPos, 0, 128);
    if (Game->GetComboFlag(Game->GetCurMap(), Game->GetCurScreen(), ComboPos) == 9 || 26 || 27 || 10 || 8 )
    {
        ComboPush = 1;
    }
    
    Link->Invisible = 0;
    if ((Link->Action == LA_WALKING) && (Link->Action != LA_GOTHURTLAND) && (ComboPush))
    {
        Set_TileAnimation(LINK_PUSH_TILE, LINK_PUSH_FRAMES, LINK_PUSH_SPEED);
    }
    Screen->DrawInteger(6, 0, 8, 0, 20, -1 , 16, 16, ComboPush, 0, 128);
}
 
void Set_TileAnimation(int tile, int frames, int speed)
{
    Link->Invisible = 1;
    if (delay > 0 ) { delay --; }
    else
    {
        frame++;
        delay = speed;
    }
    
    if (frame > frames-1)
    {
        frame = 0;
    }
    
    Screen->DrawTile(3, Link->X, Link->Y, (tile + (LINK_PUSH_FRAMES * Link->Dir)) + frame, 1, 1, 6, -1, -1, 0, 0, 0, 1, true, 128);
    //Waitframe();
}
 

Edited by Shadowblitz16, 02 November 2016 - 11:30 PM.

[Lejes]

ComboAt() isn't bugged. But I do see a flaw in one of your if statements.

if (Game->GetComboFlag(Game->GetCurMap(), Game->GetCurScreen(), ComboPos) == 9 || 26 || 27 || 10 || 8 )

You have to paste the entire check for each one of these. ZScript doesn't let you chain ORs like you were trying here. It looks at the first one, where you check if the return value of GetComboFlag() is equal to 9, and then looks at the number 26 on its own. Since any number other than 0 is typecast to "true", that if statement will always be true. If you want to shorten the statement, you could do something like this:

combo_flag = Game->GetComboFlag(Game->GetCurMap(), Game->GetCurScreen(), ComboPos);
if (combo_flag == 9 || combo_flag == 26 || combo_flag == 27 || combo_flag == 10 || combo_flag == 8 )

Although, since you're looking at the current screen, Screen->ComboF[ComboPos] would work just as well.

[Shadowblitz16]

ok thankyou Lejes

[Shadowblitz16]

@Lejes

 I realized I was checking for flags instead of types decide 

also do push combos types change before they move? if so then that could be a problem

 

Edit :

it still does the miscalculation

when I print the X and Y variables those they either return in pixels,  tiles, or rows. depending on what side of the screen I'm on

 

here is my code

Spoiler

 
//import "Custom/Scripts/Link/LinkFunctions.z"
 
const int LINK_PUSH_TILE = 34772;
const int LINK_PUSH_FRAMES = 2;
const int LINK_PUSH_SPEED = 12;
 
int frame = 0;
int delay = 0;
 
void GB_Link_Update()
{
    GB_Link_Push();
}
 
void GB_Link_Push()
{
    int ComboPos;
int ComboType = 0;
    int ComboPush = 0;
    int OffsetX = 0;
    int OffsetY = 0;
    int X = 0;
    int Y = 0;
 
if (Link->Dir == 2) { OffsetX == -1; }
else if (Link->Dir == 3) { OffsetX ==  1; }
 
if (Link->Dir == 0) { OffsetY == -1; }
else if (Link->Dir == 1) { OffsetY ==  1; }
    
    X = ((Floor(Link->X*16)/16) + 7) + (16 * OffsetX);
    Y = ((Floor(Link->Y*16)/16) + 7) + (16 * OffsetY);
    Screen->DrawInteger(6, 0, 0, 0, 20, -1 , 16, 16, X, 0, 128);
    Screen->DrawInteger(6, 24, 0, 0, 20, -1 , 16, 16, Y, 0, 128);
    
    ComboPos  = (ComboAt(X, Y));
    Screen->DrawInteger(6, 0, 8, 0, 20, -1 , 16, 16, ComboPos, 0, 128);
    ComboType = Game->GetComboType(Game->GetCurMap(), Game->GetCurScreen(), ComboPos);
    Screen->DrawInteger(6, 24, 8, 0, 20, -1 , 16, 16, ComboType, 0, 128);
 
    if ((ComboType == 9) || (ComboType == 26) || (ComboType == 27) || (ComboType == 10) || (ComboType == 8 ))
    {
        ComboPush = 1;
    }
    Screen->DrawInteger(6, 48, 8, 0, 20, -1 , 16, 16, ComboPush, 0, 128);
    
    Link->Invisible = 0;
    if ((Link->Action != LA_GOTHURTLAND) && (ComboPush) ||
        (Link->Action == LA_WALKING) && (Link->Action != LA_GOTHURTLAND) && (!CanWalk(Link->X, Link->Y, Link->Dir, 1.5, false)))
        {
       Set_TileAnimation(LINK_PUSH_TILE, LINK_PUSH_FRAMES, LINK_PUSH_SPEED);
        }
}
 
void Set_TileAnimation(int tile, int frames, int speed)
{
    Link->Invisible = 1;
    if (delay > 0 ) { delay --; }
    else
    {
        frame++;
        delay = speed;
    }
    
    if (frame > frames-1)
    {
        frame = 0;
    }
    
    Screen->DrawTile(3, Link->X, Link->Y, (tile + (LINK_PUSH_FRAMES * Link->Dir)) + frame, 1, 1, 6, -1, -1, 0, 0, 0, 1, true, 128);
    //Waitframe();
}
 

Edited by Shadowblitz16, 04 November 2016 - 02:03 PM.

[Timelord]

I believe that push combos update after Waitdraw(), but experimentation is highly advised in this regard. You can check Screen->MovingBlock* to determine if they are being pushed.

[Shadowblitz16]

@ZoriaRPG what does Screen->MovingBlock do?

also how do I use it I don't see it listed on the zc wiki

Edited by Shadowblitz16, 27 December 2016 - 02:49 PM.